From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH 1/2] SCSI: simplify scsi_io_completion() Date: Wed, 26 Nov 2008 22:13:00 -0600 Message-ID: <1227759180.3387.61.camel@localhost.localdomain> References: Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from accolon.hansenpartnership.com ([76.243.235.52]:32775 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277AbYK0END (ORCPT ); Wed, 26 Nov 2008 23:13:03 -0500 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Alan Stern Cc: Boaz Harrosh , SCSI development list On Wed, 2008-11-26 at 18:31 -0500, Alan Stern wrote: > On Wed, 26 Nov 2008, James Bottomley wrote: > > > > I was going to suggest adding a description to the ILLEGAL REQUEST > > > case. But that case arises normally under various circumstances, so > > > perhaps it wouldn't be appropriate. In fact, do you really want to > > > print out the result and sense data every time that case occurs? > > > > I think it's OK. I thought some of the CD probing routines triggered > > illegal requests, but I can't seem to see it on my test machines (it > > could be I have the wrong type of CD, though). > > So then it would make sense to add a description to that case as well. Well, yes and no ... I can't see a description being much more descriptive than what scsi_print_sense will already print ... mind you, the same is true of volume overflow. I'll remove that one. James