public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: "Koskinen Aaro (NSN - FI/Helsinki)" <aaro.koskinen@nsn.com>,
	linux-scsi@vger.kernel.org, matthew@wil.cx
Subject: Re: [PATCH] sym53c8xx_2: slave_alloc/destroy safety (2.6.27.5)
Date: Mon, 15 Dec 2008 11:13:50 -0600	[thread overview]
Message-ID: <1229361230.3293.45.camel@localhost.localdomain> (raw)
In-Reply-To: <49468C4A.2040508@cs.wisc.edu>

On Mon, 2008-12-15 at 10:56 -0600, Mike Christie wrote:
> Koskinen Aaro (NSN - FI/Helsinki) wrote:
> > Make the sym53c8xx_2 driver slave_alloc/destroy less unsafe. References
> > to the destroyed LCB are cleared from the target structure (instead of
> > leaving a dangling pointer), and when the last LCB for the target is
> > destroyed the reference to the upper layer target data is cleared. The
> > host lock is used to prevent a race with the interrupt handler. Also
> > user commands are prevented for targets with all LCBs destroyed.
> > 
> > Signed-off-by: aaro.koskinen@nsn.com
> 
> 
> Same signed off line issue. Should be Signed-off-by: Aaro Koskinen 
> <aaro.koskinen@nsn.com>.

Right, thanks!

> There were also some whitespace issues, but merging it with git-am 
> --whitespace=fix fixed them up.

You can pick these up by running the patch through scripts/checkpatch.pl

Matthew, Are you still maintaining this driver, or is it going
unmaintained and it's up to me to vet these patches?

James



  reply	other threads:[~2008-12-15 17:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-19 14:58 [PATCH] sym53c8xx_2: slave_alloc/destroy safety (2.6.27.5) Koskinen Aaro (NSN - FI/Helsinki)
2008-12-15 16:56 ` Mike Christie
2008-12-15 17:13   ` James Bottomley [this message]
2008-12-16 17:14     ` Aaro Koskinen
  -- strict thread matches above, loose matches on Subject: below --
2008-12-29 20:20 Tony Battersby
2008-12-29 20:27 Tony Battersby
2008-12-29 20:55 ` Tony Battersby
2008-12-30 10:10   ` Aaro Koskinen
2008-12-30 19:16     ` James Bottomley
2009-01-06 16:26       ` Tony Battersby
2009-01-07 10:57         ` Aaro Koskinen
2009-01-07 14:52           ` Tony Battersby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229361230.3293.45.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=aaro.koskinen@nsn.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox