Re: linux-next: Tree for December 29 (fcoe)

Randy Dunlap
2008-12-29T22:22:01Z

James Bottomley wrote:
>
> Actually, I deduce the problem is owner->name and your build has
> CONFIG_MODULE=n ... the definition of struct module is enclosed in a
> #ifdef CONFIG_MODULE.
>
> This should fix it.
>
> James

Ack. Thanks.

> ---
>
> diff --git a/drivers/scsi/fcoe/libfcoe.c b/drivers/scsi/fcoe/libfcoe.c
> index 1cb549c..fec38f6 100644
> --- a/drivers/scsi/fcoe/libfcoe.c
> +++ b/drivers/scsi/fcoe/libfcoe.c
> @@ -992,7 +992,7 @@ static int fcoe_ethdrv_get(const struct net_device *netdev)
> owner = fcoe_netdev_to_module_owner(netdev);
> if (owner) {
> printk(KERN_DEBUG "foce:hold driver module %s for %s\n",
> - owner->name, netdev->name);
> + module_name(owner), netdev->name);
> return try_module_get(owner);
> }
> return -ENODEV;
> @@ -1012,7 +1012,7 @@ static int fcoe_ethdrv_put(const struct net_device *netdev)
> owner = fcoe_netdev_to_module_owner(netdev);
> if (owner) {
> printk(KERN_DEBUG "foce:release driver module %s for %s\n",
> - owner->name, netdev->name);
> + module_name(owner), netdev->name);
> module_put(owner);
> return 0;
> }
>
>

--
~Randy