Re: linux-next: scsi tree build failure

James Bottomley
2009-04-03T01:16:40Z

On Fri, 2009-04-03 at 11:26 +1100, Stephen Rothwell wrote:
> Hi James,
>
> On Thu, 02 Apr 2009 18:23:42 +0000 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> >
> > On Thu, 2009-04-02 at 10:19 -0700, Robert Love wrote:
> > >
> > > I built using gcc version 4.3.2 (on x86_64) and didn't see this either.
>
> It may be powerpc specific, I guess.
>
> > > > diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> > > > index 5cdda6e..94e1e31 100644
> > > > --- a/drivers/scsi/fcoe/fcoe.c
> > > > +++ b/drivers/scsi/fcoe/fcoe.c
> > > > @@ -979,7 +979,6 @@ u32 fcoe_fc_crc(struct fc_frame *fp)
> > > > }
> > > > return crc;
> > > > }
> > > > -EXPORT_SYMBOL_GPL(fcoe_fc_crc);
> > > >
> > > > /**
> > > > * fcoe_xmit() - FCoE frame transmit function
> > > >
> > > >
> > Right at the moment, I need someone to verify that this is the fix,
> > since I don't have a complaining compiler myself. If it's this simple,
> > I can adjust the patch accordingly.
>
> This fixes it for me. I will apply that patch to linux-next for today
> (instead of the reverts I did yesterday).

Perfect, thanks!

I fixed up the patch in my tree, so you should not need this next time
around.

James