From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8563118EAB; Tue, 7 Jan 2025 18:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736273137; cv=none; b=OM1eOvYrBgvenYW9YS1Toli5ROlHV45wbr4GVESL7hTheMyGFhNM/5lVbxnQeolt8H7Jr7UqrNRrn8djPkhTo7g+kfK8dHEqVZaRpgDgty7M45VzbBvt/I7uW3bIyvz/DIqKbVZULz+h6Z99FuPjRy7N4k57DAospXhLGiEVVI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736273137; c=relaxed/simple; bh=wrAqqHrVAKKCplqjwQymx42sCZiDaJWIjLoGcLkfLsA=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=AFAn/1RperDVk/zl+Ks6cc/rtgKrz7dtb/x31tiwBXbIXptB3Qex9K5aWhA0UW9Jxs4HwpDph4l6O2jMED1zAmi+1V8UJgC7fUper5UHuWiUkohSg2FiYM72e16AbvK5xyjTxalCA4msYuFNi4siIcD/ilGtWx1yjUXM6gLFalM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Ev85Fl4I; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Ev85Fl4I" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 507I4Ban018493; Tue, 7 Jan 2025 18:05:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=Tixua4 /8Yt4K/L4Isd6EPPDe8vWlwzBHW/TvX++YAOc=; b=Ev85Fl4ILjJFeZ02ehq/bA ND6HfW6sPMhkbbmSdN5HdFCqyeMrnlFUr4mYfDw6f/veaMUli4OVB4zKrruqJf14 UsxRd7ApRVzOKkA71eVPnbAKFbOTN9dldhcBoIT60WgKyKAtJSNrjint9I1GBnxM W9VZbXf/R41AYBnWc0O86OA6hSJJBONOdzD98d0BkL/MOti9LXrJ00BBA9DRwX+Q +XqeJqNU43w+lnGJ2veTnPCCgYmlt1NdvkewPcHW2NMN5nc9m/tq9haZcwPoPvK3 +/sMoQX5xq/4BEzmFNHJkg1WyIlN1PtwLYOFNWFs92fOZwNZ9QAkCKGvqNVJ8aNw == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 440s0accw3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 18:05:19 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 507HR8vJ027938; Tue, 7 Jan 2025 18:05:19 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 43yhhk3k95-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jan 2025 18:05:19 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 507I5HP023986906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Jan 2025 18:05:18 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 268E458052; Tue, 7 Jan 2025 18:05:18 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B8C3258062; Tue, 7 Jan 2025 18:05:14 +0000 (GMT) Received: from [9.171.94.59] (unknown [9.171.94.59]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 7 Jan 2025 18:05:14 +0000 (GMT) Message-ID: <1230ea6b-172d-41ae-9c11-402ae7503227@linux.ibm.com> Date: Tue, 7 Jan 2025 23:35:12 +0530 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] block: fix docs for freezing of queue limits updates From: Nilay Shroff To: Christoph Hellwig , Jens Axboe Cc: Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, nbd@other.debian.org, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net References: <20250107063120.1011593-1-hch@lst.de> <20250107063120.1011593-2-hch@lst.de> <668698f6-98d9-4e23-9ea9-ce78bafe64a5@linux.ibm.com> Content-Language: en-US In-Reply-To: <668698f6-98d9-4e23-9ea9-ce78bafe64a5@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: jbKDqevyCgUeJ6YQW_pDfbACbntzIcE7 X-Proofpoint-ORIG-GUID: jbKDqevyCgUeJ6YQW_pDfbACbntzIcE7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 phishscore=0 mlxlogscore=944 lowpriorityscore=0 impostorscore=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501070149 On 1/7/25 12:31 PM, Nilay Shroff wrote: > > > On 1/7/25 12:00 PM, Christoph Hellwig wrote: >> queue_limits_commit_update is the function that needs to operate on a >> frozen queue, not queue_limits_start_update. Update the kerneldoc >> comments to reflect that. >> >> Signed-off-by: Christoph Hellwig >> --- >> block/blk-settings.c | 3 ++- >> include/linux/blkdev.h | 3 +-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/block/blk-settings.c b/block/blk-settings.c >> index 8f09e33f41f6..b6b8c580d018 100644 >> --- a/block/blk-settings.c >> +++ b/block/blk-settings.c >> @@ -413,7 +413,8 @@ int blk_set_default_limits(struct queue_limits *lim) >> * @lim: limits to apply >> * >> * Apply the limits in @lim that were obtained from queue_limits_start_update() >> - * and updated by the caller to @q. >> + * and updated by the caller to @q. The caller must have frozen the queue or >> + * ensure that there are outstanding I/Os by other means. > > Maybe typo: "ensure that there are *NO* outstanding I/Os by other means" Other than typo, everything else looks good. Once the above typo is fixed, please feel free to add: Reviewed-by: Nilay Shroff