Re: [PATCH2/5] mpt fusion: Added msi enable disable for FC,SPI,SAS [Resendig updated patch]

James Bottomley
2009-01-08T15:00:37Z

On Thu, 2009-01-08 at 07:53 -0700, Matthew Wilcox wrote:
> On Thu, Jan 08, 2009 at 02:27:16PM +0530, Kashyap, Desai wrote:
> > Added support for MSI enable/disable for different buses FC,SPI,SAS instead
> > of having single MSI enable/disable feature.
>
> Why do you think you need this?
>
> Either the system supports MSI or it doesn't. The original reason for
> only enabling MSI on SPI cards was that it reduced the number of bug
> reports since FC and SAS cards are likely to be used on machines with
> functional MSI.
>
> This is of course a horrible hack. The right thing to do is to detect
> that you've never received an interrupt, disable MSI, enable regular
> interrupts and try again.

Right ... we actually had agreement on this and a set of patches to
implement some of it that went via the PCI list ... I'll see if I can
find them.

James