Re: [PATCH2/5] mpt fusion: Added msi enable disable for FC,SPI,SAS [Resendig updated patch]

Matthew Wilcox
2009-01-08T14:53:07Z

On Thu, Jan 08, 2009 at 02:27:16PM +0530, Kashyap, Desai wrote:
> Added support for MSI enable/disable for different buses FC,SPI,SAS instead
> of having single MSI enable/disable feature.

Why do you think you need this?

Either the system supports MSI or it doesn't. The original reason for
only enabling MSI on SPI cards was that it reduced the number of bug
reports since FC and SAS cards are likely to be used on machines with
functional MSI.

This is of course a horrible hack. The right thing to do is to detect
that you've never received an interrupt, disable MSI, enable regular
interrupts and try again.

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."