From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Check for deleted device in scsi_device_online()
Date: Thu, 08 Jan 2009 10:27:36 -0600 [thread overview]
Message-ID: <1231432056.3237.25.camel@localhost.localdomain> (raw)
In-Reply-To: <20081216153352.27D4318C75E@pentland.suse.de>
On Tue, 2008-12-16 at 16:33 +0100, Hannes Reinecke wrote:
> scsi_device_online() is not just a negation of SDEV_OFFLINE,
> also devices in state SDEV_CANCEL and SDEV_DEL are
> actually offline.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> include/scsi/scsi_device.h | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
> index e96daf6..63b58d2 100644
> --- a/include/scsi/scsi_device.h
> +++ b/include/scsi/scsi_device.h
> @@ -401,7 +401,9 @@ static inline unsigned int sdev_id(struct scsi_device *sdev)
> */
> static inline int scsi_device_online(struct scsi_device *sdev)
> {
> - return sdev->sdev_state != SDEV_OFFLINE;
> + return (sdev->sdev_state != SDEV_OFFLINE &&
> + sdev->sdev_state != SDEV_CANCEL &&
> + sdev->sdev_state != SDEV_DEL);
SDEV_DEL is OK. We can't do this for SDEV_CANCEL because that will
block post removal commands (notably cache flush).
James
next prev parent reply other threads:[~2009-01-08 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 15:33 [PATCH] Check for deleted device in scsi_device_online() Hannes Reinecke
2009-01-08 16:27 ` James Bottomley [this message]
2009-01-12 8:28 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1231432056.3237.25.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox