From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [RFC] Remove SUGGEST flags
Date: Sun, 25 Jan 2009 15:09:42 -0600 [thread overview]
Message-ID: <1232917782.4586.13.camel@localhost.localdomain> (raw)
In-Reply-To: <yq1iqov4hf0.fsf@sermon.lab.mkp.net>
On Sun, 2009-01-04 at 03:14 -0500, Martin K. Petersen wrote:
> The SUGGEST_* flags in the SCSI command result have been out of fashion
> for a while and we don't actually use them in the error handling.
> Remove the remaining occurrences.
You forgot osst.c
I think this fixes it.
James
---
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c
index 0ea78d9..8f21cbb 100644
--- a/drivers/scsi/osst.c
+++ b/drivers/scsi/osst.c
@@ -280,8 +280,8 @@ static int osst_chk_result(struct osst_tape * STp, struct osst_request * SRpnt)
static int notyetprinted = 1;
printk(KERN_WARNING
- "%s:W: Warning %x (sugg. bt 0x%x, driver bt 0x%x, host bt 0x%x).\n",
- name, result, suggestion(result), driver_byte(result) & DRIVER_MASK,
+ "%s:W: Warning %x (driver bt 0x%x, host bt 0x%x).\n",
+ name, result, driver_byte(result),
host_byte(result));
if (notyetprinted) {
notyetprinted = 0;
prev parent reply other threads:[~2009-01-25 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 8:14 [RFC] Remove SUGGEST flags Martin K. Petersen
2009-01-04 9:18 ` Boaz Harrosh
2009-01-05 2:30 ` Martin K. Petersen
2009-01-25 21:09 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232917782.4586.13.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox