public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Ed Lin - PTU <ed.lin@promise.com>
Cc: linux-scsi@vger.kernel.org, Promise_Linux <Promise_Linux@promise.com>
Subject: Re: [PATCH 1/5] stex: Fix for potential invalid response
Date: Mon, 26 Jan 2009 19:16:55 +0000	[thread overview]
Message-ID: <1232997415.3248.50.camel@localhost.localdomain> (raw)
In-Reply-To: <85ABFDC4641C4847BA6088F2982EFD8F01DC8300@nonamew.ptu.promise.com>

On Mon, 2009-01-26 at 02:40 -0800, Ed Lin - PTU wrote:
> The interrupt routine is good for normal cases. However, if the firmware
> is abnormal and returns an invalid response, the driver may reuse a
> ccb structure which has already been handled. This may cause problem.
> Fix this by setting the req member to NULL. Next time we know the
> response is invalid and handle accordingly if req is NULL.
> 
> Signed-off-by: Ed Lin <ed.lin@promise.com>
> ---
> 
> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index a3a18ad..6129db4 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -746,6 +746,7 @@ static void stex_mu_intr(struct st_hba *hba, u32
> doorbell)

The patches generally look fine.  Unfortunately your email tool has
broken the line ends of most of them (like the above) which makes it
almost impossible to apply them.  Could you resend with this fixed up?

Thanks,

James



  parent reply	other threads:[~2009-01-26 19:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-26 10:40 [PATCH 1/5] stex: Fix for potential invalid response Ed Lin - PTU
2009-01-26 11:31 ` Jeff Garzik
2009-01-26 19:16 ` James Bottomley [this message]
2009-01-26 21:53   ` Ed Lin - PTU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232997415.3248.50.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=Promise_Linux@promise.com \
    --cc=ed.lin@promise.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox