From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "ed.lin" <ed.lin@promise.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/5][resend 2] stex: Fix for potential invalid request
Date: Tue, 27 Jan 2009 09:11:27 -0600 [thread overview]
Message-ID: <1233069087.3231.19.camel@localhost.localdomain> (raw)
In-Reply-To: <200901270636.04129.ed.lin@promise.com>
On Tue, 2009-01-27 at 06:36 +0800, ed.lin wrote:
> The interrupt routine is good for normal cases. However, if the firmware is
> abnormal and returns an invalid response, the driver may reuse a ccb
> structure that has already been handled. This may cause problem. Fix this by
> setting the req member to NULL. Next time we know the response is invalid and
> handle accordingly if req is NULL.
>
> Signed-off-by: Ed Lin <ed.lin@promise.com>
> ---
>
> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index a3a18ad..6129db4 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -746,6 +746,7 @@ static void stex_mu_intr(struct st_hba *hba, u32 doorbell)
> stex_copy_data(ccb, resp, size);
> }
>
> + ccb->req = NULL;
^^^^^^^^
I'm afraid all the tabs have been converted to single spaces in this
one.
Just mime attach the patches ... we can play the tune the email client
game later.
James
prev parent reply other threads:[~2009-01-27 15:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-26 22:36 [PATCH 1/5][resend 2] stex: Fix for potential invalid request ed.lin
2009-01-27 15:11 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233069087.3231.19.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=ed.lin@promise.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox