From: Harvey Harrison <harvey.harrison@gmail.com>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi: replace uses of __constant_{endian}
Date: Thu, 29 Jan 2009 15:13:30 -0800 [thread overview]
Message-ID: <1233270810.5594.10.camel@brick> (raw)
In-Reply-To: <20090129230926.GB37589@plap4-2.local>
On Thu, 2009-01-29 at 15:09 -0800, Andrew Vasquez wrote:
> On Thu, 29 Jan 2009, Harvey Harrison wrote:
>
> > The base versions handle constant folding now. Almost entirely
> > in qla2xxx/qla4xxx.
>
> Do the same semantics apply to htonl()? As, I'd rather see the
> changes from __constant_htonl() -> cpu_to_be32() be __constant_htonl()
> -> htonl():
They do, htonl is a simple wrapper around cpu_to_be32. This was just a stupid
search/replace in the two drivers. If you'd prefer it done differently, feel free.
If it's just the htonl bits I'll do a respin.
Harvey
prev parent reply other threads:[~2009-01-29 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 21:51 [PATCH] scsi: replace uses of __constant_{endian} Harvey Harrison
2009-01-29 23:09 ` Andrew Vasquez
2009-01-29 23:13 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233270810.5594.10.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=andrew.vasquez@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox