From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH] pci: enable MSI on 8132 Date: Wed, 18 Feb 2009 19:14:55 +0000 Message-ID: <1234984495.3225.48.camel@localhost.localdomain> References: <499B46B2.5040601@kernel.org> <499B6BF7.9090300@kernel.org> <499B724A.2040408@kernel.org> <499B774C.5010705@kernel.org> <499B9129.50104@kernel.org> <20090218122137.GJ16841@parisc-linux.org> <20090218100448.7f7c5b86.akpm@linux-foundation.org> <1234982285.3225.42.camel@localhost.localdomain> <499C5CAD.1070404@kernel.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from accolon.hansenpartnership.com ([76.243.235.52]:51651 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752295AbZBRTPA (ORCPT ); Wed, 18 Feb 2009 14:15:00 -0500 In-Reply-To: <499C5CAD.1070404@kernel.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Yinghai Lu Cc: Andrew Morton , david@lang.hm, Matthew Wilcox , Jesse Barnes , linux-kernel , linux-scsi@vger.kernel.org, DL-MPTFusionLinux@lsi.com, linux-pci@vger.kernel.org On Wed, 2009-02-18 at 11:08 -0800, Yinghai Lu wrote: > James Bottomley wrote: > > On Wed, 2009-02-18 at 10:04 -0800, Andrew Morton wrote: > > > >> Do we not need mpt-fix-enable-lsi-sas-to-use-msi-as-default.patch as > >> well, to fix this regression? > > > > No ... it's a separate issue. MSI was enabled for fusion SAS in 2.6.26; > > the problem msi patch which the above corrects actually has the effect > > of disabling MSI for fusion and went into 2.6.29-rc2, which isn't a > > kernel that's been tested here. > > > > so for 2.6.26, 27, 28 need pci-enable-msi-on-8132.patch I'm a bit lost with the names, but if that's the PCI quirk fix, then yes > 2.6.29 need pci-enable-msi-on-8132.patch and mpt-fix-enable-lsi-sas-to-use-msi-as-default.patch Like I said, I'm happy to have MSI completely disabled until LSI wants to comment, so no ... only the PCI quirk fix. The true fix is to have the drivers participate in dynamic testing of MSI IRQ routing, but I've somewhat lost sight of that. James