* [PATCH] scsi: libfc add missing braces to in WARN_ON
@ 2009-02-19 19:35 Harvey Harrison
2009-02-19 19:53 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: Harvey Harrison @ 2009-02-19 19:35 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi
Noticed by sparse:
drivers/scsi/libfc/fc_exch.c:286:3: warning: dubious: !x & y
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
drivers/scsi/libfc/fc_exch.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
index 66db08a..e3ee657 100644
--- a/drivers/scsi/libfc/fc_exch.c
+++ b/drivers/scsi/libfc/fc_exch.c
@@ -283,7 +283,7 @@ static void fc_exch_release(struct fc_exch *ep)
ep->destructor(&ep->seq, ep->arg);
if (ep->lp->tt.exch_put)
ep->lp->tt.exch_put(ep->lp, mp, ep->xid);
- WARN_ON(!ep->esb_stat & ESB_ST_COMPLETE);
+ WARN_ON(!(ep->esb_stat & ESB_ST_COMPLETE));
mempool_free(ep, mp->ep_pool);
}
}
--
1.6.2.rc1.175.g96b8a
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: libfc add missing braces to in WARN_ON
2009-02-19 19:35 [PATCH] scsi: libfc add missing braces to in WARN_ON Harvey Harrison
@ 2009-02-19 19:53 ` James Bottomley
2009-02-19 19:59 ` Harvey Harrison
0 siblings, 1 reply; 3+ messages in thread
From: James Bottomley @ 2009-02-19 19:53 UTC (permalink / raw)
To: Harvey Harrison; +Cc: linux-scsi
On Thu, 2009-02-19 at 11:35 -0800, Harvey Harrison wrote:
> Noticed by sparse:
> drivers/scsi/libfc/fc_exch.c:286:3: warning: dubious: !x & y
Thanks for finding this, but the patch is already queued here:
http://marc.info/?l=linux-scsi&m=123378225922727
James
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: libfc add missing braces to in WARN_ON
2009-02-19 19:53 ` James Bottomley
@ 2009-02-19 19:59 ` Harvey Harrison
0 siblings, 0 replies; 3+ messages in thread
From: Harvey Harrison @ 2009-02-19 19:59 UTC (permalink / raw)
To: James Bottomley; +Cc: linux-scsi
On Thu, 2009-02-19 at 19:53 +0000, James Bottomley wrote:
> On Thu, 2009-02-19 at 11:35 -0800, Harvey Harrison wrote:
> > Noticed by sparse:
> > drivers/scsi/libfc/fc_exch.c:286:3: warning: dubious: !x & y
>
> Thanks for finding this, but the patch is already queued here:
>
> http://marc.info/?l=linux-scsi&m=123378225922727
>
> James
>
No worries, just did a sparse run on linux-next (20090217) and saw this.
Harvey
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-19 19:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-19 19:35 [PATCH] scsi: libfc add missing braces to in WARN_ON Harvey Harrison
2009-02-19 19:53 ` James Bottomley
2009-02-19 19:59 ` Harvey Harrison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox