[PATCH] scsi: libfc add missing braces to in WARN_ON

[PATCH] scsi: libfc add missing braces to in WARN_ON

[Harvey Harrison]

Noticed by sparse:
drivers/scsi/libfc/fc_exch.c:286:3: warning: dubious: !x & y

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 drivers/scsi/libfc/fc_exch.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c
index 66db08a..e3ee657 100644
--- a/drivers/scsi/libfc/fc_exch.c
+++ b/drivers/scsi/libfc/fc_exch.c
@@ -283,7 +283,7 @@ static void fc_exch_release(struct fc_exch *ep)
 			ep->destructor(&ep->seq, ep->arg);
 		if (ep->lp->tt.exch_put)
 			ep->lp->tt.exch_put(ep->lp, mp, ep->xid);
-		WARN_ON(!ep->esb_stat & ESB_ST_COMPLETE);
+		WARN_ON(!(ep->esb_stat & ESB_ST_COMPLETE));
 		mempool_free(ep, mp->ep_pool);
 	}
 }
-- 
1.6.2.rc1.175.g96b8a

Re: [PATCH] scsi: libfc add missing braces to in WARN_ON

[James Bottomley]

On Thu, 2009-02-19 at 11:35 -0800, Harvey Harrison wrote:
> Noticed by sparse:
> drivers/scsi/libfc/fc_exch.c:286:3: warning: dubious: !x & y

Thanks for finding this, but the patch is already queued here:

http://marc.info/?l=linux-scsi&m=123378225922727

James

Re: [PATCH] scsi: libfc add missing braces to in WARN_ON

[Harvey Harrison]

On Thu, 2009-02-19 at 19:53 +0000, James Bottomley wrote:
> On Thu, 2009-02-19 at 11:35 -0800, Harvey Harrison wrote:
> > Noticed by sparse:
> > drivers/scsi/libfc/fc_exch.c:286:3: warning: dubious: !x & y
> 
> Thanks for finding this, but the patch is already queued here:
> 
> http://marc.info/?l=linux-scsi&m=123378225922727
> 
> James
> 

No worries, just did a sparse run on linux-next (20090217) and saw this.

Harvey