public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Mike Miller <mike.miller@hp.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jens Axboe <jens.axboe@oracle.com>,
	LKML <linux-kernel@vger.kernel.org>,
	LKML-scsi <linux-scsi@vger.kernel.org>,
	coldwell@redhat.com, mikem@beardog.cca.cpqcorp.net
Subject: Re: [PATCH 1/2] resubmit cciss: kernel thread to detect changes on MSA2012
Date: Fri, 06 Mar 2009 12:24:27 -0600	[thread overview]
Message-ID: <1236363867.12019.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20090306181603.GA30801@roadking.ldev.net>

On Fri, 2009-03-06 at 12:16 -0600, Mike Miller wrote:
> Patch 1 of 2
> 
> This is a resubmission of yesterdays patch to detect changes on the MSA2012.
> I hope I've addressed all concerns. This patch rearranges some of the code
> so we also have coverage in the sg and the ioctl paths as well as the main
> data path.
> 
> The MSA2012 cannot inform the driver of configuration changes since all
> management is out of band. This is a departure from any storage we have
> supported in the past. We need some way to detect changes on the topology so
> we implement this kernel thread. In some instances there's nothing we can do
> from the driver (like LUN failure) so just print out a message. In the case
> where logical volumes are added or deleted we call rebuild_lun_table to
> refreash the driver's view of the world.
> 
> Please consider this for inclusion.

I still don't quite see how the thread stops on module removal ... there
needs to be an explicit kthread_stop() somewhere in the clean up path.

James



  reply	other threads:[~2009-03-06 18:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-06 18:16 [PATCH 1/2] resubmit cciss: kernel thread to detect changes on MSA2012 Mike Miller
2009-03-06 18:24 ` James Bottomley [this message]
2009-03-06 20:00   ` Miller, Mike (OS Dev)
2009-03-06 23:29   ` Mike Miller (OS Dev)
2009-03-06 23:56     ` Andrew Morton
2009-03-07 20:36       ` James Bottomley
2009-03-07 18:52 ` Mike Miller (OS Dev)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236363867.12019.2.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=coldwell@redhat.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mike.miller@hp.com \
    --cc=mikem@beardog.cca.cpqcorp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox