From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Eric Moore <eric.moore@lsi.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/11] mpt2sas v00.100.11.11 : mpt2sas_base sources
Date: Fri, 06 Mar 2009 18:57:03 +0000 [thread overview]
Message-ID: <1236365823.12019.9.camel@localhost.localdomain> (raw)
In-Reply-To: <20090304050759.GB4194@lsil.com>
On Tue, 2009-03-03 at 22:08 -0700, Eric Moore wrote:
> +/* base shared API */
> +extern struct list_head ioc_list;
> +
> +int base_attach(struct MPT2SAS_ADAPTER *ioc);
> +void base_detach(struct MPT2SAS_ADAPTER *ioc);
This is rather generic to be in the global namespace.
> +/* config shared API */
> +void config_done(struct MPT2SAS_ADAPTER *ioc, u16 smid, u8 VF_ID, u32
> reply);
And this.
> +void ctl_init(void);
> +void ctl_exit(void);
> +void ctl_done(struct MPT2SAS_ADAPTER *ioc, u16 smid, u8 VF_ID, u32
> reply);
Ditto this.
Would it not be better to have a mpt2sas_ prefix added to all the
non-static symbols?
James
prev parent reply other threads:[~2009-03-06 18:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 5:08 [PATCH 1/11] mpt2sas v00.100.11.11 : mpt2sas_base sources Eric Moore
2009-03-06 18:57 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236365823.12019.9.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=eric.moore@lsi.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox