From: peter <pbog@us.ibm.com>
To: linux-scsi@vger.kernel.org, "Moore, Eric" <Eric.Moore@lsi.com>
Subject: Re: [RFC 0/11] mpt2sas v00.100.11.11: 3rd revision
Date: Fri, 06 Mar 2009 11:11:00 -0800 [thread overview]
Message-ID: <1236366660.10988.6.camel@gnattop> (raw)
I tried to apply and compile this set of patches with the scsi-rc-fixes
git tree and ran into a few problems.
The first issue I think is just an oversight. The Makefile in
drivers/scsi doesn't get patched so even if the CONFIG_SCSI_MPT2SAS is
define in the .config file the driver doesn't get built. I needed to add
this line to the Makefile in drivers/scsi
obj-$(CONFIG_SCSI_MPT2SAS) += mpt2sas/
The second issue is that the driver doesn't build unless
CONFIG_SCSI_MPT2SAS_LOGGING is defined. The problem seems to be that
_debug_dump_mf, from line 163 of mpt2sas_debug.h, is called from a
number of places that don't rely on CONFIG_SCSI_MPT2SAS_LOGGING. With
logging enabled the driver builds without any errors or warnings.
Peter Bogdanovic
IBM System x enablement
next reply other threads:[~2009-03-06 19:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 19:11 peter [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-03-04 5:07 [RFC 0/11] mpt2sas v00.100.11.11: 3rd revision Eric Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236366660.10988.6.camel@gnattop \
--to=pbog@us.ibm.com \
--cc=Eric.Moore@lsi.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox