From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
Tejun Heo <tj@kernel.org>
Subject: Re: Getting TRIM working
Date: Sun, 08 Mar 2009 16:32:36 -0500 [thread overview]
Message-ID: <1236547956.4861.17.camel@localhost.localdomain> (raw)
In-Reply-To: <1236547480.4861.12.camel@localhost.localdomain>
On Sun, 2009-03-08 at 16:24 -0500, James Bottomley wrote:
> The problem in the prepare is you need to set up a command with data.
> What I'm not quite clear on is why blk_rq_map_kern() on a kmalloc'd
> buffer can't be used. You'd end up with a dual bio request (one for the
> discard, one for the data), but they should tear down correctly using
> the separate bio teardowns and pass correctly into blk_rq_map_sg() which
> was the original point.
Actually, found the reason, blk_rq_map_kern will blast the original bio
from the request. You could fix this by chaining it back again at the
beginning. If that works, we could just wrap it into a block API to
prevent users from having to muck with bios.
James
next prev parent reply other threads:[~2009-03-08 21:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 19:07 Getting TRIM working Matthew Wilcox
2009-03-04 9:20 ` Boaz Harrosh
2009-03-06 19:16 ` Matthew Wilcox
2009-03-08 10:28 ` Boaz Harrosh
2009-03-08 16:54 ` Matthew Wilcox
2009-03-08 17:38 ` Boaz Harrosh
2009-03-08 21:24 ` James Bottomley
2009-03-08 21:32 ` James Bottomley [this message]
2009-03-09 8:36 ` Matthew Wilcox
2009-03-09 13:52 ` Douglas Gilbert
2009-03-09 14:03 ` INCITS Matthew Wilcox
2009-03-09 14:08 ` Getting TRIM working James Bottomley
2009-03-09 14:04 ` James Bottomley
2009-03-09 14:14 ` Matthew Wilcox
2009-03-09 15:17 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236547956.4861.17.camel@localhost.localdomain \
--to=james.bottomley@hansenpartnership.com \
--cc=bharrosh@panasas.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox