Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	Paul Wellner Bou <paul@purecodes.org>,
	SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] SCSI: increase default timeout for INQUIRY
Date: Thu, 12 Mar 2009 10:15:49 -0500	[thread overview]
Message-ID: <1236870949.3248.13.camel@localhost.localdomain> (raw)
In-Reply-To: <20090312151206.GC14425@parisc-linux.org>

On Thu, 2009-03-12 at 09:12 -0600, Matthew Wilcox wrote:
> On Thu, Mar 12, 2009 at 11:08:51AM -0400, Alan Stern wrote:
> > It's hard to see how this could cause any signficant problems, unless 
> > somebody actually depends on INQUIRY timing out.
> 
> Erm, like doing a scan of a bus?  With 15 devices to probe, you've
> increased the time from 15 * 3 = 45 seconds to 15 * 20 = 300 seconds.
> That's not cool ;-(
> 
> Maybe we could default this in the transport or something so USB can
> override it.

Well, no, this is the overall command timeout.  Each bus (that's
scannable) has its own timeout.  For instance, on a parallel bus this is
250ms per device ... don't respond in that time, we return
DID_NO_CONNECT.

I think what Alan is saying is that some USB devices will take >5s to
respond to an initial inquiry.  Remember that USB isn't actually a
scannable bus.  We get told there's a device there and we have to send
an INQUIRY to classify it.

James



  reply	other threads:[~2009-03-12 15:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12 15:08 [PATCH] SCSI: increase default timeout for INQUIRY Alan Stern
2009-03-12 15:12 ` Matthew Wilcox
2009-03-12 15:15   ` James Bottomley [this message]
2009-03-12 15:24     ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1236870949.3248.13.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=paul@purecodes.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox