[RFC] hpsa: addressing review comments

[RFC] hpsa: addressing review comments

[Mike Miller (OS Dev)]

sorry, I fat fingered the address first time around...

Date: Fri, 13 Mar 2009 09:18:49 -0500
From: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net>
To: LKML <linux-kernel@vger.kernel.org>, lkml-scis@beardog.cca.cpqcorp.net
Cc: Steve Cameron <scameron@beardog.cca.cpqcorp.net>, tom.lawler@hp.com,
	iss_storagedev@hp.com
Subject: [RFC] hpsa: addressing review comments

I have a question about the hpsa driver we recently released. We've received
quite a few comments, very positive overall. When we make the changes noted,
i.e., rip out /proc, style changes, etc., do we submit patches for that? Or
repost the entire driver with the appropriate changelog?

Thanks,
mikem


----- End forwarded message -----

Re: [RFC] hpsa: addressing review comments

[James Bottomley]

On Fri, 2009-03-13 at 09:20 -0500, Mike Miller (OS Dev) wrote:
> sorry, I fat fingered the address first time around...
> 
> Date: Fri, 13 Mar 2009 09:18:49 -0500
> From: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net>
> To: LKML <linux-kernel@vger.kernel.org>, lkml-scis@beardog.cca.cpqcorp.net
> Cc: Steve Cameron <scameron@beardog.cca.cpqcorp.net>, tom.lawler@hp.com,
> 	iss_storagedev@hp.com
> Subject: [RFC] hpsa: addressing review comments
> 
> I have a question about the hpsa driver we recently released. We've received
> quite a few comments, very positive overall. When we make the changes noted,
> i.e., rip out /proc, style changes, etc., do we submit patches for that? Or
> repost the entire driver with the appropriate changelog?

Either is fine with me.  Posting update patches is very useful to people
who want to see what changes have been made between versions.  When we
iterate to a final version, then you can repost the whole thing (so it
can go into the tree as one to avoid bisection problems).

James

Re: [RFC] hpsa: addressing review comments

[Mike Miller (OS Dev)]

On Fri, Mar 13, 2009 at 09:24:56AM -0500, James Bottomley wrote:
> On Fri, 2009-03-13 at 09:20 -0500, Mike Miller (OS Dev) wrote:
> > sorry, I fat fingered the address first time around...
> > 
> > Date: Fri, 13 Mar 2009 09:18:49 -0500
> > From: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net>
> > To: LKML <linux-kernel@vger.kernel.org>, lkml-scis@beardog.cca.cpqcorp.net
> > Cc: Steve Cameron <scameron@beardog.cca.cpqcorp.net>, tom.lawler@hp.com,
> > 	iss_storagedev@hp.com
> > Subject: [RFC] hpsa: addressing review comments
> > 
> > I have a question about the hpsa driver we recently released. We've received
> > quite a few comments, very positive overall. When we make the changes noted,
> > i.e., rip out /proc, style changes, etc., do we submit patches for that? Or
> > repost the entire driver with the appropriate changelog?
> 
> Either is fine with me.  Posting update patches is very useful to people
> who want to see what changes have been made between versions.  When we
> iterate to a final version, then you can repost the whole thing (so it
> can go into the tree as one to avoid bisection problems).
> 

Thanks, James.