Re: [PATCH 1/2] Add 'tpgs' sysfs attribute for SCSI devices

[Chandra Seetharaman <sekharan@us.ibm.com>]

Looks good to me

Acked-by: Chandra Seetharaman <sekharan@us.ibm.com>

On Thu, 2009-03-19 at 09:06 +0100, Hannes Reinecke wrote:
> We need the 'TGPS' setting of the inquiry data
> to properly support ALUA. So just add an accessor
> for the stored inquiry data and display it
> in sysfs.
> 
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
>  drivers/scsi/scsi_sysfs.c  |   10 ++++++++++
>  include/scsi/scsi_device.h |    5 +++++
>  2 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index fa4711d..cccdd89 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -586,6 +586,15 @@ sdev_store_timeout (struct device *dev, struct device_attribute *attr,
>  static DEVICE_ATTR(timeout, S_IRUGO | S_IWUSR, sdev_show_timeout, sdev_store_timeout);
> 
>  static ssize_t
> +sdev_show_tpgs (struct device *dev, struct device_attribute *attr, char *buf)
> +{
> +	struct scsi_device *sdev;
> +	sdev = to_scsi_device(dev);
> +	return snprintf(buf, 20, "%d\n", scsi_device_tpgs(sdev));
> +}
> +static DEVICE_ATTR(tpgs, S_IRUGO, sdev_show_tpgs, NULL);
> +
> +static ssize_t
>  store_rescan_field (struct device *dev, struct device_attribute *attr,
>  		    const char *buf, size_t count)
>  {
> @@ -745,6 +754,7 @@ static struct attribute *scsi_sdev_attrs[] = {
>  	&dev_attr_vendor.attr,
>  	&dev_attr_model.attr,
>  	&dev_attr_rev.attr,
> +	&dev_attr_tpgs.attr,
>  	&dev_attr_rescan.attr,
>  	&dev_attr_delete.attr,
>  	&dev_attr_state.attr,
> diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
> index 3f566af..6ac6321 100644
> --- a/include/scsi/scsi_device.h
> +++ b/include/scsi/scsi_device.h
> @@ -450,6 +450,11 @@ static inline int scsi_device_protection(struct scsi_device *sdev)
>  	return sdev->scsi_level > SCSI_2 && sdev->inquiry[5] & (1<<0);
>  }
> 
> +static inline int scsi_device_tpgs(struct scsi_device *sdev)
> +{
> +	return (sdev->inquiry[5] >> 4) &3;
> +}
> +
>  #define MODULE_ALIAS_SCSI_DEVICE(type) \
>  	MODULE_ALIAS("scsi:t-" __stringify(type) "*")
>  #define SCSI_DEVICE_MODALIAS_FMT "scsi:t-0x%02x"