From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kleber S. Souza" Subject: Re: [PATCH] ipr: ipr_remove() marked __devexit Date: Fri, 17 Apr 2009 16:08:34 -0300 Message-ID: <1239995314.6143.1.camel@zeppelin.austin.ibm.com> References: <1237839145.13011.54.camel@zeppelin.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from e24smtp01.br.ibm.com ([32.104.18.85]:51851 "EHLO e24smtp01.br.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762062AbZDQTJS (ORCPT ); Fri, 17 Apr 2009 15:09:18 -0400 Received: from mailhub1.br.ibm.com (mailhub1.br.ibm.com [9.18.232.109]) by e24smtp01.br.ibm.com (8.13.1/8.13.1) with ESMTP id n3HJODiY011412 for ; Fri, 17 Apr 2009 16:24:13 -0300 Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n3HJ9Yn71491088 for ; Fri, 17 Apr 2009 16:09:35 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n3HJ9E7H031831 for ; Fri, 17 Apr 2009 16:09:14 -0300 Received: from [9.18.253.249] (dyn536942.br.ibm.com [9.18.253.249]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n3HJ99bj031753 for ; Fri, 17 Apr 2009 16:09:10 -0300 In-Reply-To: <1237839145.13011.54.camel@zeppelin.austin.ibm.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "linux-scsi@vger.kernel.org" Hi, Any comments on this patch? It was acked by Brian King, do I need to do anything else to get it accepted? Thanks, Kleber On Mon, 2009-03-23 at 17:12 -0300, Kleber Sacilotto de Souza wrote: > Marking the ipr clean up function ipr_remove() as __devexit and using > __devexit_p() macro in its address reference. > > > Signed-off-by: Kleber Sacilotto de Souza > Signed-off-by: Breno Leitao > Acked-by: Brian King > --- > drivers/scsi/ipr.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c > index 0782900..bc39ac6 100644 > --- a/drivers/scsi/ipr.c > +++ b/drivers/scsi/ipr.c > @@ -7674,7 +7674,7 @@ static void __ipr_remove(struct pci_dev *pdev) > * Return value: > * none > **/ > -static void ipr_remove(struct pci_dev *pdev) > +static void __devexit ipr_remove(struct pci_dev *pdev) > { > struct ipr_ioa_cfg *ioa_cfg = pci_get_drvdata(pdev); > > @@ -7850,7 +7850,7 @@ static struct pci_driver ipr_driver = { > .name = IPR_NAME, > .id_table = ipr_pci_table, > .probe = ipr_probe, > - .remove = ipr_remove, > + .remove = __devexit_p(ipr_remove), > .shutdown = ipr_shutdown, > .err_handler = &ipr_err_handler, > }; > -- > -- Kleber S. Souza IBM Linux Technology Center