From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] sd: no errors allowed during async probing
Date: Tue, 02 Jun 2009 13:19:31 -0500 [thread overview]
Message-ID: <1243966771.4280.4.camel@mulgrave.site> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0906021401350.3228-100000@iolanthe.rowland.org>
On Tue, 2009-06-02 at 14:05 -0400, Alan Stern wrote:
> This patch (as1252) fixes a bug in the sd probing code. When the
> probe routine was split up into a synchronous and an asynchronous
> part, too much was put into the asynchronous part. It's important
> that all the possible failure modes occur synchronously, so that the
> driver core knows whether the probe was successful even before the
> async part is complete.
>
> Another bug is that device removal has to wait for the async probing
> to finish! The patch addresses both bugs, by moving some code back
> from sd_probe_async() to sd_probe() and by adding a call to
> async_synchronize_full() at the start of sd_remove().
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
This is pretty much line by line identical to the patch I already
posted, isn't it? If not, help me understand what's different.
James
next prev parent reply other threads:[~2009-06-02 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 18:05 [PATCH] sd: no errors allowed during async probing Alan Stern
2009-06-02 18:19 ` James Bottomley [this message]
2009-06-02 18:41 ` Alan Stern
2009-06-02 20:20 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243966771.4280.4.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox