From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: 2.6.30-rc8 Oops whilst booting Date: Mon, 08 Jun 2009 12:49:22 -0500 Message-ID: <1244483362.4079.358.camel@mulgrave.site> References: <200906061959.55592.chris2553@googlemail.com> <200906062215.30571.chris2553@googlemail.com> <1244381140.30664.12.camel@ht.satnam> <1244413881.18742.31.camel@ht.satnam> <2f9e3044bafcae848f74a1492b0ea471.squirrel@neil.brown.name> <1244460875.12644.2.camel@ht.satnam> <1244480796.4079.301.camel@mulgrave.site> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from bedivere.hansenpartnership.com ([66.63.167.143]:49761 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbZFHRtX (ORCPT ); Mon, 8 Jun 2009 13:49:23 -0400 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Linus Torvalds Cc: Chris Clayton , Jaswinder Singh Rajput , NeilBrown , linux-kernel@vger.kernel.org, scsi , Tejun Heo , Arjan van de Ven On Mon, 2009-06-08 at 10:42 -0700, Linus Torvalds wrote: > > On Mon, 8 Jun 2009, James Bottomley wrote: > > > > I think it's a bug in the async code. It's providing cookies too high > > because it doesn't stop after it finds a running entry. > > > > Can we try this as the fix? > > Ok, this looks likely. > > That said, why doesn't that function look like this? That's probably a better style ... or simply put an if ... else if to make it exclusive. James