From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Anirban Chakraborty <anirban.chakraborty@qlogic.com>
Cc: "Styner, Douglas W" <douglas.w.styner@intel.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Tripathi, Sharad C" <sharad.c.tripathi@intel.com>,
"Ma, Chinang" <chinang.ma@intel.com>,
"Prickett, Terry O" <terry.o.prickett@intel.com>,
"Wilcox, Matthew R" <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH] qla2xxx: Resolved a performance issue in interrupt handler
Date: Wed, 10 Jun 2009 11:17:57 -0500 [thread overview]
Message-ID: <1244650677.17432.0.camel@mulgrave.site> (raw)
In-Reply-To: <38D5FA1B-4CCC-46FB-8793-4131AF6AAD05@qlogic.com>
On Wed, 2009-06-10 at 09:09 -0700, Anirban Chakraborty wrote:
> On Jun 10, 2009, at 8:52 AM, Styner, Douglas W wrote:
>
> >
> > Anirban Chakraborty [mailto:anirban.chakraborty@qlogic.com] write:
> >>
> >> You got it right. Basically we are doing:
> >> 1. baseline scsi-misc + earlier patch
> >> 2. baseline scsi-misc + this patch
> >> And then compare 1 and 2.
> >
> > Results are as follows:
> > Total interrupts are down slightly (-0.8%), QLA interrupts are flat
> > (-0.1%) Cycles for qla2xxx_intr_handler up from .77% to .92%.
>
> So, it looks like using spin_lock_irqsave is doing a better job than
> globally disabling the sharing of the interrupt via IRQF_DISABLED.
OK, so just drop the msix changes and resubmit ... it'll have to go in
SCSI misc, but once the merge window is over, you can request a backport
to stable.
James
next prev parent reply other threads:[~2009-06-10 16:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 18:42 [PATCH] qla2xxx: Resolved a performance issue in interrupt handler Anirban Chakraborty
2009-06-09 19:32 ` James Bottomley
2009-06-09 20:34 ` Anirban Chakraborty
2009-06-09 20:40 ` James Bottomley
2009-06-09 21:28 ` Giridhar Malavali
2009-06-09 21:41 ` Matthew Wilcox
2009-06-09 21:46 ` James Bottomley
2009-06-09 21:40 ` Anirban Chakraborty
2009-06-09 21:43 ` Matthew Wilcox
2009-06-09 21:46 ` Anirban Chakraborty
2009-06-09 21:47 ` Matthew Wilcox
2009-06-09 22:30 ` Anirban Chakraborty
[not found] ` <D7C42C27E6CB1E4D8CBDF2F81EA92A26035402EBA0@azsmsx501.amr.corp.intel.com>
[not found] ` <2796FDDF-31EA-44E2-8856-84A22F31A01F@qlogic.com>
2009-06-10 15:52 ` Styner, Douglas W
2009-06-10 16:09 ` Anirban Chakraborty
2009-06-10 16:17 ` James Bottomley [this message]
2009-06-10 16:18 ` Matthew Wilcox
2009-06-10 18:29 ` Anirban Chakraborty
2009-06-10 18:32 ` [PATCH] qla2xxx: Resolved a performance issue in interrupt Andrew Vasquez
2009-06-10 19:10 ` James Bottomley
2009-06-10 19:48 ` Matthew Wilcox
2009-06-10 20:55 ` Anirban Chakraborty
2009-06-12 22:48 ` Styner, Douglas W
2009-06-12 22:52 ` [PATCH] qla2xxx: Resolved a performance issue in interrupt - this time with data Styner, Douglas W
2009-06-12 23:32 ` Anirban Chakraborty
[not found] <B8134F80-B547-4E04-890A-6B646D2BA3E8@qlogic.com>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1244650677.17432.0.camel@mulgrave.site \
--to=james.bottomley@hansenpartnership.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=chinang.ma@intel.com \
--cc=douglas.w.styner@intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew.r.wilcox@intel.com \
--cc=sharad.c.tripathi@intel.com \
--cc=terry.o.prickett@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox