[PATCH] fcoe: convert to %pM

[PATCH] fcoe: convert to %pM

[Johannes Berg]

print_mac is being deprecated, and %pM makes for smaller
code anyway.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 drivers/scsi/fcoe/libfcoe.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- wireless-testing.orig/drivers/scsi/fcoe/libfcoe.c	2009-07-15 17:12:02.000000000 +0200
+++ wireless-testing/drivers/scsi/fcoe/libfcoe.c	2009-07-15 17:12:17.000000000 +0200
@@ -1104,7 +1104,6 @@ static void fcoe_ctlr_timeout(unsigned l
 	struct fcoe_fcf *sel;
 	struct fcoe_fcf *fcf;
 	unsigned long next_timer = jiffies + msecs_to_jiffies(FIP_VN_KA_PERIOD);
-	DECLARE_MAC_BUF(buf);
 	u8 send_ctlr_ka;
 	u8 send_port_ka;
 
@@ -1128,9 +1127,8 @@ static void fcoe_ctlr_timeout(unsigned l
 		fcf = sel;		/* the old FCF may have been freed */
 		if (sel) {
 			printk(KERN_INFO "libfcoe: host%d: FIP selected "
-			       "Fibre-Channel Forwarder MAC %s\n",
-			       fip->lp->host->host_no,
-			       print_mac(buf, sel->fcf_mac));
+			       "Fibre-Channel Forwarder MAC %pM\n",
+			       fip->lp->host->host_no, sel->fcf_mac);
 			memcpy(fip->dest_addr, sel->fcf_mac, ETH_ALEN);
 			fip->port_ka_time = jiffies +
 					    msecs_to_jiffies(FIP_VN_KA_PERIOD);

Re: [PATCH] fcoe: convert to %pM

[Robert Love]

On Wed, 2009-07-15 at 08:21 -0700, Johannes Berg wrote:
> print_mac is being deprecated, and %pM makes for smaller
> code anyway.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

Thanks Johannes.

Acked-by: Robert Love <robert.w.love@intel.com>

> ---
>  drivers/scsi/fcoe/libfcoe.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> --- wireless-testing.orig/drivers/scsi/fcoe/libfcoe.c	2009-07-15 17:12:02.000000000 +0200
> +++ wireless-testing/drivers/scsi/fcoe/libfcoe.c	2009-07-15 17:12:17.000000000 +0200
> @@ -1104,7 +1104,6 @@ static void fcoe_ctlr_timeout(unsigned l
>  	struct fcoe_fcf *sel;
>  	struct fcoe_fcf *fcf;
>  	unsigned long next_timer = jiffies + msecs_to_jiffies(FIP_VN_KA_PERIOD);
> -	DECLARE_MAC_BUF(buf);
>  	u8 send_ctlr_ka;
>  	u8 send_port_ka;
>  
> @@ -1128,9 +1127,8 @@ static void fcoe_ctlr_timeout(unsigned l
>  		fcf = sel;		/* the old FCF may have been freed */
>  		if (sel) {
>  			printk(KERN_INFO "libfcoe: host%d: FIP selected "
> -			       "Fibre-Channel Forwarder MAC %s\n",
> -			       fip->lp->host->host_no,
> -			       print_mac(buf, sel->fcf_mac));
> +			       "Fibre-Channel Forwarder MAC %pM\n",
> +			       fip->lp->host->host_no, sel->fcf_mac);
>  			memcpy(fip->dest_addr, sel->fcf_mac, ETH_ALEN);
>  			fip->port_ka_time = jiffies +
>  					    msecs_to_jiffies(FIP_VN_KA_PERIOD);
> 
>