From: "Anil Veerabhadrappa" <anilgv@broadcom.com>
To: James.Bottomley@HansenPartnership.com
Cc: linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com,
michaelc@cs.wisc.edu, mchan@broadcom.com
Subject: [PATCH 1/2] bnx2i : Fix CMDSN jump issue seen during cable pull test
Date: Wed, 29 Jul 2009 21:49:48 -0700 [thread overview]
Message-ID: <1248929388.26650.349.camel@anilgv-desktop> (raw)
In-Reply-To: <1245805860.9829.50.camel@anilgv-desktop>
* Without the fix bnx2i would fail tt->xmit_task() when link is down
* libiscsi would have already incremented session->cmdsn before calling
bnx2i's xmit_task() entry point and will just return the command to
SCSI-ML when xmit_task() fails. libiscsi does not retract the session->cmdsn
as the command was never sent on wire
* It is generally good idea for LLD, bnx2i to accept the scsi cmnd/nopout
and let upper layer timeout and go though normal session recovery process
* When link is down, unsolicited nopout will not be accepted by bnx2i and
connection will never enter recovery state. This fix is required for MPIO
to work corectly
Signed-off-by: Anil Veerabhadrappa <anilgv@broadcom.com>
---
drivers/scsi/bnx2i/bnx2i_iscsi.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
index f741219..9535bb6 100644
--- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
+++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
@@ -1160,9 +1160,6 @@ static int bnx2i_task_xmit(struct iscsi_task *task)
struct bnx2i_cmd *cmd = task->dd_data;
struct iscsi_cmd *hdr = (struct iscsi_cmd *) task->hdr;
- if (test_bit(ADAPTER_STATE_LINK_DOWN, &hba->adapter_state))
- return -ENOTCONN;
-
if (!bnx2i_conn->is_bound)
return -ENOTCONN;
--
1.5.4.3
next prev parent reply other threads:[~2009-07-30 4:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-24 1:11 [PATCH 1/3] bnx2i remove not so useful global variable bnx2i_reg_devices Anil Veerabhadrappa
2009-06-24 20:00 ` Mike Christie
2009-06-28 14:33 ` James Bottomley
2009-06-28 15:46 ` Michael Chan
2009-06-28 17:25 ` James Bottomley
2009-06-28 19:59 ` Michael Chan
2009-06-28 20:11 ` James Bottomley
2009-07-09 1:21 ` [PATCH] BNX2I: register given device with cnic if shost != NULL in ep_connect() Anil Veerabhadrappa
2009-07-09 6:21 ` Mike Christie
2009-07-09 7:15 ` Michael Chan
2009-07-09 14:39 ` Anil Veerabhadrappa
2009-07-09 17:43 ` Mike Christie
2009-07-09 20:32 ` Anil Veerabhadrappa
2009-07-09 20:49 ` Anil Veerabhadrappa
2009-07-30 4:49 ` Anil Veerabhadrappa [this message]
2009-07-30 15:31 ` [PATCH 1/2] bnx2i : Fix CMDSN jump issue seen during cable pull test Mike Christie
2009-09-11 17:38 ` [PATCH 1/1] BNX2I - Fix context mapping issue for architectures with PAGE_SIZE != 4096 Anil Veerabhadrappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248929388.26650.349.camel@anilgv-desktop \
--to=anilgv@broadcom.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=michaelc@cs.wisc.edu \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox