Re: [PATCH 4/7] sd: add support for WRITE SAME (16) with unmap bit

Christoph Hellwig
2009-08-30T17:14:38Z

On Sun, Aug 30, 2009 at 03:12:09PM +0400, Sergei Shtylyov wrote:
>> + printk(KERN_INFO "umap, lba = 0x%lld, len = %d\n",
>>
>
> So, is it hex or decimal? :-)
>
>> + bio->bi_sector, bio_sectors(bio));
>>
>
> Since bio->bi_sector can either be 4 or 8 bytes, you need a cast to
> unsigned long long here.

Indeed. But as this is justa debug printk that slipped through I will
just remove it completely in the next iteration.