From: Daniel Walker <dwalker@fifo99.com>
To: akataria@vmware.com
Cc: James Bottomley <James.Bottomley@suse.de>,
Rolf Eike Beer <eike-kernel@sf-tec.de>,
Brian King <brking@linux.vnet.ibm.com>,
"Chetan.Loke@Emulex.Com" <Chetan.Loke@Emulex.Com>,
Matthew Wilcox <matthew@wil.cx>,
Roland Dreier <rdreier@cisco.com>,
Bart Van Assche <bvanassche@acm.org>,
Robert Love <robert.w.love@intel.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Mike Christie <michaelc@cs.wisc.edu>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
pv-drivers@vmware.com
Subject: Re: [PATCH] SCSI driver for VMware's virtual HBA - V4.
Date: Tue, 08 Sep 2009 18:26:36 -0700 [thread overview]
Message-ID: <1252459596.14793.46.camel@desktop> (raw)
In-Reply-To: <1252458903.24914.73.camel@ank32.eng.vmware.com>
On Tue, 2009-09-08 at 18:15 -0700, Alok Kataria wrote:
> +typedef struct PVSCSIRingCmpDesc {
> + u64 context;
> + u64 dataLen;
> + u32 senseLen;
> + u16 hostStatus;
> + u16 scsiStatus;
> + u32 _pad[2];
> +} __packed PVSCSIRingCmpDesc;
I get a lot of checkpatch warnings due to the typedefs here.. They are
usually frowned upon, and it really does make you code look alien ..
> +#define PVSCSI_MEM_SPACE_COMMAND_PAGE 0
> +#define PVSCSI_MEM_SPACE_INTR_STATUS_PAGE 1
> +#define PVSCSI_MEM_SPACE_MISC_PAGE 2
> +#define PVSCSI_MEM_SPACE_KICK_IO_PAGE 4
> +#define PVSCSI_MEM_SPACE_MSIX_TABLE_PAGE 6
> +#define PVSCSI_MEM_SPACE_MSIX_PBA_PAGE 7
Why not use an enum for the above? Your using enums in the rest of your
code..
Daniel
next prev parent reply other threads:[~2009-09-09 1:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 1:15 [PATCH] SCSI driver for VMware's virtual HBA - V4 Alok Kataria
2009-09-09 1:26 ` Daniel Walker [this message]
2009-09-09 5:01 ` Alok Kataria
2009-09-09 5:54 ` Rolf Eike Beer
2009-09-09 16:56 ` Alok Kataria
2009-09-29 17:05 ` [Pv-drivers] " Alok Kataria
2009-09-09 21:00 ` Anthony Liguori
2009-09-09 21:51 ` Alok Kataria
2009-09-09 22:12 ` Anthony Liguori
2009-09-09 23:08 ` Christoph Hellwig
2009-09-09 23:34 ` Anthony Liguori
2009-09-09 23:54 ` Jeremy Fitzhardinge
2009-09-10 0:11 ` Anthony Liguori
2009-09-10 23:43 ` Alok Kataria
2009-09-10 23:43 ` Alok Kataria
2009-09-14 3:05 ` [Pv-drivers] " Alok Kataria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252459596.14793.46.camel@desktop \
--to=dwalker@fifo99.com \
--cc=Chetan.Loke@Emulex.Com \
--cc=James.Bottomley@suse.de \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=brking@linux.vnet.ibm.com \
--cc=bvanassche@acm.org \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=michaelc@cs.wisc.edu \
--cc=pv-drivers@vmware.com \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=robert.w.love@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox