From: Alok Kataria <akataria@vmware.com>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: Daniel Walker <dwalker@fifo99.com>,
James Bottomley <James.Bottomley@suse.de>,
Brian King <brking@linux.vnet.ibm.com>,
"Chetan.Loke@Emulex.Com" <Chetan.Loke@emulex.com>,
Matthew Wilcox <matthew@wil.cx>,
Roland Dreier <rdreier@cisco.com>,
Bart Van Assche <bvanassche@acm.org>,
Robert Love <robert.w.love@intel.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Mike Christie <michaelc@cs.wisc.edu>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"pv-drivers@vmware.com" <pv-drivers@vmware.com>
Subject: Re: [PATCH] SCSI driver for VMware's virtual HBA - V4.
Date: Wed, 09 Sep 2009 09:56:52 -0700 [thread overview]
Message-ID: <1252515412.16631.6.camel@ank32.eng.vmware.com> (raw)
In-Reply-To: <200909090754.22778.eike-kernel@sf-tec.de>
Hi Eike,
On Tue, 2009-09-08 at 22:54 -0700, Rolf Eike Beer wrote:
> Alok Kataria wrote:
>
> > +/* Command line parameters */
> > +static int pvscsi_ring_pages = PVSCSI_DEFAULT_NUM_PAGES_PER_RING;
> > +static int pvscsi_msg_ring_pages = PVSCSI_DEFAULT_NUM_PAGES_MSG_RING;
> > +static int pvscsi_cmd_per_lun = PVSCSI_DEFAULT_QUEUE_DEPTH;
> > +static int pvscsi_disable_msi;
> > +static int pvscsi_disable_msix;
> > +static int pvscsi_use_msg = true;
>
> Should be bool.
Yeah, could be done, though I think I will do this later as an
incremental change or piggyback it if something else comes up.
>
> Do I get annoying? ;)
:) Do you want the truth ? ;).
Actually its good that the code is being reviewed in so much details.
Thanks for your time on this.
--Alok
>
> Eike
next prev parent reply other threads:[~2009-09-09 16:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 1:15 [PATCH] SCSI driver for VMware's virtual HBA - V4 Alok Kataria
2009-09-09 1:26 ` Daniel Walker
2009-09-09 5:01 ` Alok Kataria
2009-09-09 5:54 ` Rolf Eike Beer
2009-09-09 16:56 ` Alok Kataria [this message]
2009-09-29 17:05 ` [Pv-drivers] " Alok Kataria
2009-09-09 21:00 ` Anthony Liguori
2009-09-09 21:51 ` Alok Kataria
2009-09-09 22:12 ` Anthony Liguori
2009-09-09 23:08 ` Christoph Hellwig
2009-09-09 23:34 ` Anthony Liguori
2009-09-09 23:54 ` Jeremy Fitzhardinge
2009-09-10 0:11 ` Anthony Liguori
2009-09-10 23:43 ` Alok Kataria
2009-09-10 23:43 ` Alok Kataria
2009-09-14 3:05 ` [Pv-drivers] " Alok Kataria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252515412.16631.6.camel@ank32.eng.vmware.com \
--to=akataria@vmware.com \
--cc=Chetan.Loke@emulex.com \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=brking@linux.vnet.ibm.com \
--cc=bvanassche@acm.org \
--cc=dwalker@fifo99.com \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=michaelc@cs.wisc.edu \
--cc=pv-drivers@vmware.com \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=robert.w.love@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox