From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Walker Subject: Re: [RFC PATCH 0/19] A kernel-level configfs enabled generic target engine for Linux v2.6.32 Date: Fri, 11 Sep 2009 19:37:40 -0700 Message-ID: <1252723060.28368.48.camel@desktop> References: <1252720508.2067.196.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from fifo99.com ([67.223.236.141]:43759 "EHLO fifo99.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757230AbZILChF (ORCPT ); Fri, 11 Sep 2009 22:37:05 -0400 In-Reply-To: <1252720508.2067.196.camel@haakon2.linux-iscsi.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Nicholas A. Bellinger" Cc: LKML , linux-scsi , Andrew Morton , Greg KH , Douglas Gilbert , James Bottomley , Hannes Reinecke , FUJITA Tomonori , Mike Christie , Joel Becker , "Martin K. Petersen" , Christoph Hellwig , Linus Torvalds , Alan Stern , Boaz Harrosh , Florian Haas , Philipp Reisner On Fri, 2009-09-11 at 18:55 -0700, Nicholas A. Bellinger wrote: > There is cleanup work continuing to make the TCM code to use > dprintk(), > and some include cleanups, and other minor fixes. The code has also > been run through checkpatch again since the posting in April, and all > errors have been removed, with the exception of one ConfigFS macro > define triggering a checkpatch false positive. One show stopping issue is that your adding new semaphore usage in patch 5 and 16 (and in 16 it's a LOCKED one wtf!!). Which you should not be doing .. You need to really evaluate the warnings from checkpatch, cause those still have meaning.. It's basically telling you what you should be doing in the warnings.. For instance, don't add new semaphore usage, and it tells you what you need to be using in place of them.. Also typedefs are frowned upon, so you could remove those.. Daniel