From: Daniel Walker <dwalker@fifo99.com>
To: "Yang, Bo" <Bo.Yang@lsi.com>
Cc: "James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"James.Bottomley@suse.de" <James.Bottomley@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"akpm@osdl.org" <akpm@osdl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/12] scsi: megaraid_sas - tape drive support fix
Date: Sun, 20 Sep 2009 20:40:35 -0700 [thread overview]
Message-ID: <1253504435.9654.221.camel@desktop> (raw)
In-Reply-To: <4B6A08C587958942AA3002690DD4F8C35C5123FA@cosmail02.lsi.com>
Your patches all have numerous serious style problems.. There are far
too many to even give a summary here, and they are all different kinds
of problems..
You would need to fix all these issues before these patches could move
forward. Could you run scripts/checkpatch.pl on you patches and fix all
the issues that it reports?
Daniel
next prev parent reply other threads:[~2009-09-21 3:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 2:21 [PATCH 1/12] scsi: megaraid_sas - tape drive support fix Yang, Bo
2009-09-21 3:40 ` Daniel Walker [this message]
2009-09-21 15:22 ` Yang, Bo
2009-09-21 15:57 ` Daniel Walker
2009-09-21 16:04 ` Yang, Bo
2009-10-06 20:12 ` Yang, Bo
2009-12-06 15:24 ` [PATCH 1/4] scsi: megaraid_sas - Zero pad_0 in mfi structure Yang, Bo
2009-12-06 15:30 ` [PATCH 2/4] scsi: megaraid_sas - add the ld list to driver Yang, Bo
2009-12-06 15:39 ` [PATCH 3/4] scsi: megaraid_sas - driver fixed the device update issue Yang, Bo
2009-12-06 15:42 ` [PATCH 4/4] scsi: megaraid_sas - version and documentation update Yang, Bo
[not found] ` <3A916D859199814BBB666188F96EB165013979165E@cosmail02.lsi.com>
2010-05-06 14:42 ` [PATCH 1/7] scsi: megaraid_sas - Online controller Reset Support (OCR) PART-I Yang, Bo
2010-05-06 15:41 ` [PATCH 2/7] scsi: megaraid_sas - Online controller Reset Support (OCR) PART-II Yang, Bo
2010-05-26 16:35 ` [PATCH 2/7] scsi: megaraid_sas - Online controller Reset Support (OCR)-II : Driver return RESET in timeout routine Yang, Bo
2010-06-10 3:25 ` [PATCH 4/12] scsi: megaraid_sas - Online controller Reset Support (OCR) " Yang, Bo
2010-08-05 20:16 ` Yang, Bo
2010-05-06 15:52 ` [PATCH 3/7] scsi: megaraid_sas - Online COntroller Reset (OCR) PART-III Yang, Bo
2010-05-07 12:54 ` Tomas Henzl
2010-05-18 20:58 ` Yang, Bo
2010-05-06 16:04 ` [PATCH 4/7] scsi: megaraid_sas - support devices update flag Yang, Bo
2010-06-10 4:16 ` [PATCH 9/12] " Yang, Bo
2010-06-18 21:05 ` Yang, Bo
2010-08-05 20:28 ` Yang, Bo
2010-05-06 16:17 ` [PATCH 5/7] scsi: megaraid_sas - Add input parameter for max_sectors Yang, Bo
2010-05-06 16:34 ` [PATCH 6/7] scsi: megaraid_sas - Add three times Online controller reset Yang, Bo
2010-05-25 16:17 ` [PATCH 6/7] scsi: megaraid_sas - Add three times Online controller reset - V2 Tomas Henzl
2010-05-25 17:32 ` James Bottomley
2010-05-26 15:48 ` Tomas Henzl
2010-05-26 21:08 ` Yang, Bo
2010-05-28 13:31 ` Tomas Henzl
2010-06-10 4:21 ` [PATCH 11/12] scsi: megaraid_sas - Add three times Online controller reset Yang, Bo
2010-06-18 21:11 ` Yang, Bo
2010-08-05 20:35 ` Yang, Bo
2010-05-06 16:37 ` [PATCH 7/7] scsi: megaraid_sas - Version and documentation update Yang, Bo
2010-06-10 4:22 ` [PATCH 12/12] " Yang, Bo
2010-06-18 21:13 ` Yang, Bo
2010-08-05 20:38 ` Yang, Bo
2010-05-26 16:25 ` [PATCH 1/7] scsi: megaraid_sas - Online Controller Reset - I: Change the Chips related functions and Add the Chip reset functions Yang, Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253504435.9654.221.camel@desktop \
--to=dwalker@fifo99.com \
--cc=Bo.Yang@lsi.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=James.Bottomley@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).