RE: [PATCH 2/14] bfa: Brocade BFA FC SCSI driver (bfa1)

[James Bottomley <James.Bottomley@HansenPartnership.com>]

On Thu, 2009-09-24 at 11:08 -0700, Jing Huang wrote:
> > > Hi Daniel,
> > >
> > > I did run checkpatch.pl and it didn't report any ERROR or WARNING. Do
> > you use any specific flags?
> > 
> > No nothing special .. I run it in the following way,
> > 
> > ./scripts/checkpatch.pl this-is-the-test.patch
> > 
> > or
> > 
> > cat this-is-the-test.patch | ./scripts/checkpatch.pl -
> > 
> > how did you run it? Usually it will report something like the following
> > if it finds nothing,
> > 
> > total: 0 errors, 0 warnings, XXX lines checked
> > 
> > Your patch has no obvious style problems and is ready for submission.
> > 
> > 
> > 
> > Daniel
> 
> Thanks. I found the problem. I tried the latest checkpatch in 2.6.31
> and it generates a lot of ERRORs about putting parentheses for return.
> I have been using an older version of checkpatch for patch submission
> all the time, and therefore I didn't see any problem. I will fix them
> and resubmit the patch.

Actually, could you send an incremental diff ... I'll put this in the
tree because it's about time it got wider testing in linux-next.

James