Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: Yugendranath R Singh <yugendranath.s@hcl.in>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	Andy Yan <ayan@marvell.com>, Ke Wei <kewei@marvell.com>
Subject: Re: [PATCH] drivers/scsi/mvsas: mvsas driver supported device list to inlcude Adaptec ASC-1045/1405 SAS/SATA Controllers
Date: Thu, 01 Oct 2009 15:27:21 +0000	[thread overview]
Message-ID: <1254410841.3885.6.camel@mulgrave.site> (raw)
In-Reply-To: <4CA9DA403FFEC64AA62B3C295F8D47B7212674D868@CHN-HCLT-EVS07.HCLT.CORP.HCL.IN>

On Thu, 2009-10-01 at 20:35 +0530, Yugendranath R Singh wrote:
> Please find the patch below which adds the Adaptec ASC 1045/1405
> controllers to mvsas driver supported device list, for kernel version
> 2.6.31.1.

I think you need to read Documentation/SubmittingPatches first.

I need a Signed-off-by line

The patch also should be generated against either upstream or one of the
SCSI git trees.  Backporting to a stable tree is something that gets
done after the patch is upstream. (doesn't really matter in this case,
since the code is unchanged).

> -----
> diff -uprN a/linux-2.6.31.1/drivers/scsi/mvsas/mv_init.c b/linux-2.6.31.1/drivers/scsi/mvsas/mv_init.c
> --- a/linux-2.6.31.1/drivers/scsi/mvsas/mv_init.c       2009-09-24 21:15:25.000000000 +0530
> +++ b/linux-2.6.31.1/drivers/scsi/mvsas/mv_init.c       2009-10-02 00:03:53.000000000 +0530
> @@ -653,6 +653,7 @@ static struct pci_device_id __devinitdat
>         { PCI_VDEVICE(MARVELL, 0x6485), chip_6485 },
>         { PCI_VDEVICE(MARVELL, 0x9480), chip_9480 },
>         { PCI_VDEVICE(MARVELL, 0x9180), chip_9180 },
> +       { PCI_VDEVICE(ADAPTEC2, 0x0450), chip_6440 },
> 
>         { }     /* terminate list */
>  };

This patch actually won't apply (try it from the email list).  Your
mailer has converted the tabs to spaces and done other text mangling.
We have a file: Documentation/email-clients.txt that tries to advise on
the various mailer settings to make this work.  However, if you have
outlook, there's apparently nothing that can be done and you'll need to
attach the patch instead of inlining it.

James



      reply	other threads:[~2009-10-01 15:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-01 15:05 [PATCH] drivers/scsi/mvsas: mvsas driver supported device list to inlcude Adaptec ASC-1045/1405 SAS/SATA Controllers Yugendranath R Singh
2009-10-01 15:27 ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1254410841.3885.6.camel@mulgrave.site \
    --to=james.bottomley@suse.de \
    --cc=ayan@marvell.com \
    --cc=kewei@marvell.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=yugendranath.s@hcl.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox