From: James Bottomley <James.Bottomley@suse.de>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: tmscsim: Missing parentheses in dc390_init_hw()?
Date: Tue, 03 Nov 2009 17:07:59 -0600 [thread overview]
Message-ID: <1257289679.2454.23.camel@mulgrave.site> (raw)
In-Reply-To: <4AF0B4E1.2030407@gmail.com>
On Tue, 2009-11-03 at 23:55 +0100, Roel Kluin wrote:
> Same oddness, are there parentheses missing here?
>
> Thanks, Roel
>
> diff --git a/drivers/scsi/tmscsim.c b/drivers/scsi/tmscsim.c
> index 9a42734..25e6d63 100644
> --- a/drivers/scsi/tmscsim.c
> +++ b/drivers/scsi/tmscsim.c
> @@ -2408,8 +2408,8 @@ static void __devinit dc390_init_hw(struct dc390_acb *pACB, u8 index)
>
> /* Negation */
> DC390_write8(CtrlReg4, pACB->glitch_cfg | /* glitch eater */
> - (dc390_eepromBuf[index][EE_MODE2] & ACTIVE_NEGATION) ?
> - NEGATE_REQACKDATA : 0);
> + ((dc390_eepromBuf[index][EE_MODE2] & ACTIVE_NEGATION) ?
> + NEGATE_REQACKDATA : 0));
This one looks more possible ... but given it's hw init, the original
meaning is also possible ... and supported by the fact that the hw
works.
James
prev parent reply other threads:[~2009-11-03 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 22:55 tmscsim: Missing parentheses in dc390_init_hw()? Roel Kluin
2009-11-03 23:07 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257289679.2454.23.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox