From: James Bottomley <James.Bottomley@suse.de>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Roel Kluin <roel.kluin@gmail.com>,
linux-scsi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] zfcp: Test kmalloc failure in scsi_get_vpd_page()
Date: Thu, 05 Nov 2009 13:41:33 -0600 [thread overview]
Message-ID: <1257450093.10355.28.camel@mulgrave.site> (raw)
In-Reply-To: <4AF28CCF.8020605@panasas.com>
On Thu, 2009-11-05 at 10:29 +0200, Boaz Harrosh wrote:
> On 11/04/2009 07:50 PM, James Bottomley wrote:
> > On Wed, 2009-11-04 at 18:18 +0200, Boaz Harrosh wrote:
> >
> > The point of checking is not to send a VPD inquiry to USB devices that
> > don't support it. These have a very limited range of supported VPD
> > pages.
> >
>
> OK thanks. But maybe just define a MIN_INQUIRY_SIZE instead of hard
> coded 32 everywhere, and use that. So in future if such a device is
> found we can easily change it.
So the minimum inquiry size would actually be 36 ... from
scsi_scan.c ... and that's hard coded to a value too.
> (Never say never ;-))
I'm hoping that by the time USB devices get complex enough to need more
than 28 VPD pages, they've actually discovered what conforming to the
standards means.
James
next prev parent reply other threads:[~2009-11-05 19:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 16:21 [PATCH] zfcp: Test kmalloc failure in scsi_get_vpd_page() Roel Kluin
2009-08-27 23:45 ` James Bottomley
2009-08-30 11:45 ` Boaz Harrosh
2009-08-30 14:35 ` James Bottomley
2009-11-03 18:33 ` James Bottomley
2009-11-04 8:54 ` Boaz Harrosh
2009-11-04 15:09 ` James Bottomley
2009-11-04 16:18 ` Boaz Harrosh
2009-11-04 17:50 ` James Bottomley
2009-11-05 8:29 ` Boaz Harrosh
2009-11-05 19:41 ` James Bottomley [this message]
2009-11-08 9:19 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257450093.10355.28.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox