Re: [PATCH] libsas: do not set res = 0 in sas_ex_discover_dev()

[James Bottomley <James.Bottomley@suse.de>]

On Thu, 2009-11-05 at 15:56 +0800, jack wang wrote:
> Hi, James
> 
> What is the status of this this patch .  we have test it  Srinivas
> have confirmed it does work.
> 
> Please consider to include it in your rc-fixes tree.

OK, this one never actually made it to the list.  I think this was
because all the patches contained text/html attachments which the list
kills sight unseen because it thinks they're spam.  You really have to
make sure you only send text plain and patch attachments for them to get
through.

For simplicity, the patch is below for list review.

James

---

From: jack wang <jack_wang@usish.com>
Subject: [PATCH] libsas: do not set res = 0 in sas_ex_discover_dev()

We should not set res to 0 in function sas_ex_discover_dev  in order to let
it discover it further when wide port hotplug in .

Signed-off-by: Tom Peng <tom_peng@usish.com>
Signed-off-by: Jack Wang <jack_wang@usish.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
---
 drivers/scsi/libsas/sas_expander.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
index b338195..33cf988 100644
--- a/drivers/scsi/libsas/sas_expander.c
+++ b/drivers/scsi/libsas/sas_expander.c
@@ -960,7 +960,6 @@ static int sas_ex_discover_dev(struct domain_device *dev, int phy_id)
 
 			}
 		}
-		res = 0;
 	}
 
 	return res;
-- 
1.6.4.2