public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: ayan@marvell.com
Cc: jeff@garzik.org, linux-scsi@vger.kernel.org, qswang@marvell.com,
	jfeng@marvell.com
Subject: Re: [PATCH 5/7]MVSAS:Optimization for DMA buffer
Date: Sat, 14 Nov 2009 11:41:01 -0600	[thread overview]
Message-ID: <1258220461.4070.7.camel@mulgrave.site> (raw)
In-Reply-To: <20091109121952.GD32336@Andy.marvell.com>

On Mon, 2009-11-09 at 20:19 +0800, Andy Yan wrote:
> -       if (!pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
> -               rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
> +       if (!pci_set_dma_mask(pdev, DMA_64BIT_MASK)) {
> +               rc = pci_set_consistent_dma_mask(pdev, DMA_64BIT_MASK);

So I might not agree with the people who pointlessly churn our
interfaces while adding no value but the old form now warns, so you
can't just revert this change any more:

drivers/scsi/mvsas/mv_init.c: In function 'pci_go_64':
drivers/scsi/mvsas/mv_init.c:460: warning: 'DMA_nnBIT_MASK' is deprecated
drivers/scsi/mvsas/mv_init.c:461: warning: 'DMA_nnBIT_MASK' is deprecated
drivers/scsi/mvsas/mv_init.c:463: warning: 'DMA_nnBIT_MASK' is deprecated
drivers/scsi/mvsas/mv_init.c:471: warning: 'DMA_nnBIT_MASK' is deprecated
drivers/scsi/mvsas/mv_init.c:477: warning: 'DMA_nnBIT_MASK' is deprecated

Please remove this reversion from the diff.

Thanks,

James



      reply	other threads:[~2009-11-14 17:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09 12:19 [PATCH 5/7]MVSAS:Optimization for DMA buffer Andy Yan
2009-11-14 17:41 ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258220461.4070.7.camel@mulgrave.site \
    --to=james.bottomley@suse.de \
    --cc=ayan@marvell.com \
    --cc=jeff@garzik.org \
    --cc=jfeng@marvell.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=qswang@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox