From: James Bottomley <James.Bottomley@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Yang Hongyang <yanghy@cn.fujitsu.com>,
Alan Cox <alan@linux.intel.com>,
linux-scsi@vger.kernel.org, Alan Cox <alan@redhat.com>
Subject: Re: [PATCH 02/38] move atp870u_remove to .devexit.text
Date: Tue, 24 Nov 2009 15:38:16 -0600 [thread overview]
Message-ID: <1259098696.4549.643.camel@mulgrave.site> (raw)
In-Reply-To: <1259096853-18909-2-git-send-email-u.kleine-koenig@pengutronix.de>
On Tue, 2009-11-24 at 22:06 +0100, Uwe Kleine-König wrote:
> The function atp870u_remove is used only wrapped by __devexit_p so define
> it using __devexit.
But there's really no point to this. HOTPLUG is always defined on SCSI
systems that have these drivers, which means that _devinit/exit are
nops. That makes the change purely cosmetic and not worth churning two
dozen drivers for.
Even for the EMBEDDED cases that should care about this, the maintainers
have indicated that the memory savings simply aren't worth the hassle of
tracking the sectional updates.
James
next prev parent reply other threads:[~2009-11-24 21:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1259096853-18909-1-git-send-email-u.kleine-koenig@pengutronix.de>
2009-11-24 21:06 ` [PATCH 02/38] move atp870u_remove to .devexit.text Uwe Kleine-König
[not found] ` <1259096853-18909-3-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-4-git-send-email-u.kleine-koenig@pengutronix.de>
2009-11-24 21:07 ` [PATCH 05/38] move initio_remove_one " Uwe Kleine-König
[not found] ` <1259096853-18909-6-git-send-email-u.kleine-koenig@pengutronix.de>
2009-11-24 21:07 ` [PATCH 07/38] move lasi700_driver_remove " Uwe Kleine-König
[not found] ` <1259096853-18909-8-git-send-email-u.kleine-koenig@pengutronix.de>
2009-11-24 21:07 ` [PATCH 09/38] move megaraid_detach_one " Uwe Kleine-König
[not found] ` <1259096853-18909-10-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-11-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-12-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-13-git-send-email-u.kleine-koenig@pengutronix.de>
2009-11-24 21:07 ` [PATCH 14/38] move NCR_Q720_remove " Uwe Kleine-König
[not found] ` <1259096853-18909-15-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-16-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-17-git-send-email-u.kleine-koenig@pengutronix.de>
2009-11-24 21:07 ` [PATCH 18/38] move sgiwd93_remove " Uwe Kleine-König
2009-11-24 21:07 ` [PATCH 19/38] move snirm710_driver_remove " Uwe Kleine-König
[not found] ` <1259096853-18909-20-git-send-email-u.kleine-koenig@pengutronix.de>
2009-11-24 21:07 ` [PATCH 21/38] move stex_remove " Uwe Kleine-König
[not found] ` <1259096853-18909-22-git-send-email-u.kleine-koenig@pengutronix.de>
2009-11-24 21:07 ` [PATCH 23/38] move zalon_remove " Uwe Kleine-König
[not found] ` <1259096853-18909-24-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-25-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-26-git-send-email-u.kleine-koenig@pengutronix.de>
2009-11-24 21:07 ` [PATCH 27/38] move bfad_pci_remove " Uwe Kleine-König
2009-11-24 21:38 ` James Bottomley [this message]
2009-11-25 9:26 ` [PATCH 02/38] move atp870u_remove " Uwe Kleine-König
2009-11-25 13:38 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259098696.4549.643.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox