From: James Bottomley <James.Bottomley@suse.de>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Anil Veerabhadrappa <anilgv@broadcom.com>,
linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com,
mchan@broadcom.com, poswald@novell.com
Subject: Re: [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver
Date: Thu, 10 Dec 2009 09:43:12 -0600 [thread overview]
Message-ID: <1260459792.2457.75.camel@mulgrave.site> (raw)
In-Reply-To: <4B2060AE.7090005@cs.wisc.edu>
On Wed, 2009-12-09 at 20:45 -0600, Mike Christie wrote:
> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
But not by checkpatch:
ERROR: trailing whitespace
#23: FILE: drivers/scsi/bnx2i/bnx2i_init.c:90:
+^I^Iprintk(KERN_ALERT "bnx2i: unknown device, 0x%x\n", $
total: 1 errors, 0 warnings, 13 lines checked
I've fixed it up. And the several other whitespace problems in the rest
of the patch set.
James
next prev parent reply other threads:[~2009-12-10 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 19:39 [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver Anil Veerabhadrappa
2009-12-10 2:45 ` Mike Christie
2009-12-10 15:43 ` James Bottomley [this message]
2009-12-10 18:24 ` Anil Veerabhadrappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260459792.2457.75.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=anilgv@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=michaelc@cs.wisc.edu \
--cc=open-iscsi@googlegroups.com \
--cc=poswald@novell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox