public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: james.smart@emulex.com, linux-scsi@vger.kernel.org,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH,RESEND] scsi: use __uX types for headers exported to user space
Date: Thu, 07 Jan 2010 09:40:29 -0500	[thread overview]
Message-ID: <1262875229.3025.4.camel@mulgrave.site> (raw)
In-Reply-To: <1262874005-25089-1-git-send-email-jacmet@sunsite.dk>

On Thu, 2010-01-07 at 15:20 +0100, Peter Korsgaard wrote:
> Commit 9e4f5e29 (FC Pass Thru support) exported a number of header files
> in include/scsi to user space, but didn't change the uX types to the
> userspace-compatible __uX types. Without that you'll get compile errors
> when including them - E.G.:
> 
> /tmp/include/scsi/scsi.h:145: error: expected specifier-qualifier-list
> before ‘u8’
> 
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
>  No feedback since 27/11, resending.

OK, so to summarise the list discussion, the current status is that the
SCSI exports are irrelevant because glibc currently ignores the
include/scsi namespace provided by the kernel.  So, we have three
options:

     1. Bring our exports up to the point where they can replace glibc's
        include/scsi/scsi.h and the rest.  This requires a line by line
        analysis of what's in glibc and an update to our include to
        provide or remove as necessary.  After this is done we can try
        to persuade the glibc people to turn over the include/scsi
        namespace to us.
     2. Kill the kbuild exports and make everyone go via the glibc tree
        (current state).
     3. Move the kernel include/scsi to a more conventional namespace
        (like inside include/linux) so glibc will pick it up.

So far we've had people supporting all three.  I'm inclined to say that
I'd favour 1, but the first patch trying to do any of them would be the
best starting ground for a discussion.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-01-07 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-07 14:20 [PATCH,RESEND] scsi: use __uX types for headers exported to user space Peter Korsgaard
2010-01-07 14:39 ` Boaz Harrosh
2010-01-07 14:40 ` James Bottomley [this message]
2010-01-07 14:59   ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1262875229.3025.4.camel@mulgrave.site \
    --to=james.bottomley@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=jacmet@sunsite.dk \
    --cc=james.smart@emulex.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox