From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alok Kataria Subject: Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers Date: Tue, 19 Jan 2010 10:19:04 -0800 Message-ID: <1263925144.24149.7.camel@ank32.eng.vmware.com> References: <20100119173819.GA28630@dtor-ws.eng.vmware.com> <1263924273.24149.1.camel@ank32.eng.vmware.com> <1263924492.4398.5.camel@mulgrave.site> Reply-To: akataria@vmware.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-outbound-2.vmware.com ([65.115.85.73]:43553 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755136Ab0ASS0X (ORCPT ); Tue, 19 Jan 2010 13:26:23 -0500 In-Reply-To: <1263924492.4398.5.camel@mulgrave.site> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Dmitry Torokhov , VMware PV-Drivers , "linux-scsi@vger.kernel.org" On Tue, 2010-01-19 at 10:08 -0800, James Bottomley wrote: > On Tue, 2010-01-19 at 10:04 -0800, Alok Kataria wrote: > > On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote: > > > pvscsi_setup_msix() expects 'irq' argument to be an int but is being > > > passed unsigned int. Unsigned int is more proper type for IRQ number > > > so let's use it. This shuts off a compile warning with recent > > > compilers. > > > > > > Signed-off-by: Dmitry Torokhov > > > > LGTM. > > > > Signed-off-by: Alok N Kataria > > That would be acked-by unless you want to resend the patch to me? I > don't have an unmangled copy of it, so someone needs to send it to the > scsi list. > Acked-by is fine with me too. If its an hassle to pick these lines after the patch is sent, I am totally fine if you pick the patch without my Acked-by or SOB line, just wanted to acknowledge that the change is fine by me. Thanks, Alok > Thanks, > > James > >