Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers

[James Bottomley <James.Bottomley@suse.de>]

On Tue, 2010-01-19 at 10:19 -0800, Alok Kataria wrote:
> On Tue, 2010-01-19 at 10:08 -0800, James Bottomley wrote:
> > On Tue, 2010-01-19 at 10:04 -0800, Alok Kataria wrote:
> > > On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote:
> > > > pvscsi_setup_msix() expects 'irq' argument to be an int but is being
> > > > passed unsigned int. Unsigned int is more proper type for IRQ number
> > > > so let's use it. This shuts off a compile warning with recent
> > > > compilers.
> > > > 
> > > > Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
> > > 
> > > LGTM.
> > > 
> > > Signed-off-by: Alok N Kataria <akataria@vmware.com>
> > 
> > That would be acked-by unless you want to resend the patch to me?  I
> > don't have an unmangled copy of it, so someone needs to send it to the
> > scsi list.
> > 
> Acked-by is fine with me too. If its an hassle to pick these lines after
> the patch is sent, I am totally fine if you pick the patch without my
> Acked-by or SOB line, just wanted to acknowledge that the change is fine
> by me. 

The difference is Acked-by means you looked at the patch and said it was
OK.  This is fairly essential if you want the change to go into the SCSI
tree because otherwise it goes in my pile to look at ordered by
importance (and changes like this tend to land close to the bottom).

If you want to send it to me yourself, you resend it with a
signed-off-by tag (this tracks whose hands the change passed through).

James