From: James Bottomley <James.Bottomley@suse.de>
To: Gal Rosen <galr@storwize.com>
Cc: linux-scsi@vger.kernel.org, James.Smart@Emulex.Com
Subject: Re: [PATCH] SCSI: Synchronization issue while deleting vport
Date: Mon, 08 Mar 2010 22:42:44 +0530 [thread overview]
Message-ID: <1268068364.10660.0.camel@mulgrave.site> (raw)
In-Reply-To: <1264061732.31083.51.camel@galr-linux>
On Thu, 2010-01-21 at 10:15 +0200, Gal Rosen wrote:
> diff --git a/drivers/scsi/scsi_transport_fc.c
> b/drivers/scsi/scsi_transport_fc.c
> index 5fd64e7..be96eb0 100644
> --- a/drivers/scsi/scsi_transport_fc.c
> +++ b/drivers/scsi/scsi_transport_fc.c
> @@ -1217,6 +1217,15 @@ store_fc_vport_delete(struct device *dev,
> struct device_attribute *attr,
> {
> struct fc_vport *vport = transport_class_to_vport(dev);
> struct Scsi_Host *shost = vport_to_shost(vport);
> + unsigned int flags;
> +
> + spin_lock_irqsave(shost->host_lock, flags);
For a spinlock flags has to be unsigned long, not unsigned int ... but I
can fix that up.
James
prev parent reply other threads:[~2010-03-08 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 8:15 [PATCH] SCSI: Synchronization issue while deleting vport Gal Rosen
2010-01-23 2:00 ` James Smart
2010-01-24 7:20 ` Gal Rosen
2010-01-25 15:35 ` James Smart
2010-03-08 8:05 ` Gal Rosen
2010-03-08 16:42 ` James Smart
2010-03-08 17:12 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268068364.10660.0.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=James.Smart@Emulex.Com \
--cc=galr@storwize.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox