From: James Bottomley <James.Bottomley@suse.de>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Christof Schmitt <christof.schmitt@de.ibm.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_transport_fc: Initialize sysfs attributes with sysfs_attr_init
Date: Tue, 16 Mar 2010 13:49:04 -0700 [thread overview]
Message-ID: <1268772544.30314.1.camel@mulgrave.site> (raw)
In-Reply-To: <4B9FEEBB.8090809@cs.wisc.edu>
On Tue, 2010-03-16 at 15:48 -0500, Mike Christie wrote:
> On 03/16/2010 05:14 AM, Christof Schmitt wrote:
> > With the new lockdep tracking in sysfs, sysfs_attr_init has to be used
> > for initializing all non-static sysfs attributes. Otherwise, lockdep
> > will warn about the missing initialization with:
> >
> > Mar 15 09:19:49 t6345029 kernel: BUG: key 000000002f5ae350 not in .data!
> > Mar 15 09:19:49 t6345029 kernel: BUG: key 000000002f5ae388 not in .data!
> > Mar 15 09:19:49 t6345029 kernel: BUG: key 000000002f5ae3c0 not in .data!
> > Mar 15 09:19:49 t6345029 kernel: BUG: key 000000002f5ae3f8 not in .data!
> >
>
> I think iscsi needs this too, but I am not see this error message. I
> just tried iscsi and fc/lpfc with linus's tree and did not see those
> errors for either. What .config settings do I need for this? I have:
It's a lot worse than that ... every transport class plus some of the
core attributes will need this.
> CONFIG_LOCKDEP=y
> CONFIG_DEBUG_LOCKDEP=y
>
> are there other lockdep settings?
I also don't see a problem in my systems, so I'd appreciate an answer to
this too.
James
next prev parent reply other threads:[~2010-03-16 20:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 10:14 [PATCH] scsi_transport_fc: Initialize sysfs attributes with sysfs_attr_init Christof Schmitt
2010-03-16 20:48 ` Mike Christie
2010-03-16 20:49 ` James Bottomley [this message]
2010-03-17 13:20 ` Christof Schmitt
2010-03-20 17:44 ` James Bottomley
2010-03-22 10:13 ` Christof Schmitt
2010-03-22 19:16 ` Alex.Iannicelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268772544.30314.1.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=christof.schmitt@de.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox