From: James Bottomley <James.Bottomley@suse.de>
To: "ravi.anand" <ravi.anand@qlogic.com>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
Vikas Chaudhary <vikas.chaudhary@qlogic.com>,
Linux-SCSI Mailing List <linux-scsi@vger.kernel.org>,
Karen Higgins <karen.higgins@qlogic.com>,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH 09/11] qla4xxx: Added support for ISP82XX
Date: Wed, 28 Apr 2010 18:25:02 -0500 [thread overview]
Message-ID: <1272497102.14756.46.camel@mulgrave.site> (raw)
In-Reply-To: <B065E21A-3DB2-4303-B0DC-FB41F97F0225@qlogic.com>
On Wed, 2010-04-28 at 16:11 -0700, ravi.anand wrote:
> On Apr 27, 2010, at 11:37 PM, Mike Christie wrote:
>
> > On 04/28/2010 01:14 AM, Vikas Chaudhary wrote:
> >> Signed-off-by: Vikas Chaudhary<vikas.chaudhary@qlogic.com>
> >> Signed-off-by: Ravi Anand<ravi.anand@qlogic.com>
> >> Signed-off-by: Karen Higgins<karen.higgins@qlogic.com>
> >> ---
> >> drivers/scsi/qla4xxx/Kconfig | 4 +-
> >> drivers/scsi/qla4xxx/Makefile | 2 +-
> >> drivers/scsi/qla4xxx/ql4_def.h | 145 ++-
> >> drivers/scsi/qla4xxx/ql4_fw.h | 144 +++-
> >> drivers/scsi/qla4xxx/ql4_glbl.h | 115 ++-
> >> drivers/scsi/qla4xxx/ql4_init.c | 190 ++-
> >> drivers/scsi/qla4xxx/ql4_inline.h | 2 +-
> >> drivers/scsi/qla4xxx/ql4_iocb.c | 73 +-
> >> drivers/scsi/qla4xxx/ql4_isr.c | 400 +++++-
> >> drivers/scsi/qla4xxx/ql4_mbx.c | 185 ++-
> >> drivers/scsi/qla4xxx/ql4_nvram.c | 2 +-
> >> drivers/scsi/qla4xxx/ql4_nvram.h | 6 +-
> >> drivers/scsi/qla4xxx/ql4_nx.c | 2556 ++++++++++++++++++++++++
> >> +++++++++++++
> >> drivers/scsi/qla4xxx/ql4_nx.h | 703 ++++++++++
> >> drivers/scsi/qla4xxx/ql4_os.c | 693 ++++++++---
> >> 15 files changed, 4831 insertions(+), 389 deletions(-)
> >> create mode 100644 drivers/scsi/qla4xxx/ql4_nx.c
> >
> >
> > I did not review this patch adding new hw support due to waiting on
> > comments about the other patches.
>
> James,
>
> Are you going to pull in all the other patches except this one ?
> We can resubmit this one once Mike get a chance to review it.
Um, so I understood the comment to mean that Mike is still waiting for
you to comment on his questions and sugestions for patches 9,8,6,1 of
the original 12 patch series from 6 April ... unless I missed them?
As long as this 11 patch series reviews and applies independently, I'm
fine with dropping this and taking the rest.
> Just trying to understand how to proceed from here.
>
> >
> >
> > The other patches look ok now. They just have comment about adding a
> > KERN_ in the printks but I think that is ignorable. Add a:
> > Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
> >
> >
> > This patch:
> > [PATCH 08/11] qla4xxx: fix ql4_mbx tcp_source_port_num
> > is already in Linus's tree I think, so it can be dropped by James
> > if he
> > likes the patches.
>
>
> OK. Was not really sure, so pushed it to make sure it gets rolled in.
Yes, will just drop it.
James
next prev parent reply other threads:[~2010-04-28 23:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 6:14 [PATCH 09/11] qla4xxx: Added support for ISP82XX Vikas Chaudhary
2010-04-28 6:37 ` Mike Christie
[not found] ` <B065E21A-3DB2-4303-B0DC-FB41F97F0225@qlogic.com>
2010-04-28 23:25 ` James Bottomley [this message]
2010-04-29 1:45 ` Mike Christie
2010-04-29 6:17 ` Rolf Eike Beer
2010-05-28 6:22 ` Mike Christie
2010-06-11 8:44 ` Vikas Chaudhary
2010-06-12 0:39 ` Mike Christie
2010-06-12 9:56 ` Ravi Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272497102.14756.46.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=karen.higgins@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=randy.dunlap@oracle.com \
--cc=ravi.anand@qlogic.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).