From: Mike Anderson <andmike@linux.vnet.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: Jens Axobe <jens.axboe@oracle.com>,
	James Bottomley <James.Bottomley@suse.de>,
	dm-devel@redhat.com
Subject: [PATCH 9/9] scsi: Add blk_request_aborted check
Date: Mon,  3 May 2010 20:37:08 -0700	[thread overview]
Message-ID: <1272944228-30511-10-git-send-email-andmike@linux.vnet.ibm.com> (raw)
In-Reply-To: <1272944228-30511-1-git-send-email-andmike@linux.vnet.ibm.com>
Add a blk_request_aborted check to scsi_requeue_request. This allows for a
single check in a common requeue function to determine if a request has been
aborted.
Signed-off-by: Mike Anderson <andmike@linux.vnet.ibm.com>
Cc: James Bottomley <James.Bottomley@suse.de>
---
 drivers/scsi/scsi_lib.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 73182db..68e4bd7 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -121,11 +121,19 @@ static void scsi_requeue_request(struct request_queue *q, struct request *req,
 	unsigned long flags;
 
 	spin_lock_irqsave(q->queue_lock, flags);
+	if (blk_request_aborted(req)) {
+		spin_unlock_irqrestore(q->queue_lock, flags);
+		scsi_unprep_fn(q, req);
+		blk_end_request_all(req, -EIO);
+		goto out;
+	}
+
 	if (unprep)
 		scsi_unprep_request(req);
 	blk_requeue_request(q, req);
 	spin_unlock_irqrestore(q->queue_lock, flags);
 
+out:
 	scsi_run_queue(q);
 }
 
-- 
1.6.6.1
next prev parent reply	other threads:[~2010-05-04  3:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-04  3:36 [PATCH 0/9] blk: scsi: blk abort queue updates Mike Anderson
2010-05-04  3:37 ` [PATCH 1/9] blk: Do not abort requests if queue is stopped Mike Anderson
2010-05-04 10:40   ` Hannes Reinecke
2010-05-04 10:45   ` Jens Axboe
2010-05-05  4:52     ` Mike Anderson
2010-05-05 18:13       ` Mike Christie
2010-05-05 18:18         ` Mike Anderson
2010-05-04  3:37 ` [PATCH 2/9] blk: In elv_abort_queue skip requests with REQ_DONTPREP set Mike Anderson
2010-05-04 10:40   ` Hannes Reinecke
2010-05-04 10:47   ` Jens Axboe
2010-05-04 17:58     ` Mike Anderson
2010-05-05  8:21       ` Jens Axboe
2010-05-04  3:37 ` [PATCH 3/9] blk: Add a unprep_rq_fn Mike Anderson
2010-05-04 10:41   ` Hannes Reinecke
2010-05-04  3:37 ` [PATCH 4/9] blk: Call unprep_fn from elv_abort_queue is available Mike Anderson
2010-05-04 10:42   ` Hannes Reinecke
2010-05-04 10:42   ` [dm-devel] " Hannes Reinecke
2010-05-04  3:37 ` [PATCH 5/9] scsi: Add a scsi_unprep_fn Mike Anderson
2010-05-04 10:43   ` [dm-devel] " Hannes Reinecke
2010-05-04 10:48   ` Jens Axboe
2010-05-04  3:37 ` [PATCH 6/9] blk: Add request atomic flag for abort Mike Anderson
2010-05-04 10:43   ` [dm-devel] " Hannes Reinecke
2010-05-04  3:37 ` [PATCH 7/9] blk: Mark requests aborted Mike Anderson
2010-05-04 10:44   ` Hannes Reinecke
2010-05-04  3:37 ` [PATCH 8/9] scsi: Add scsi_requeue_request function Mike Anderson
2010-05-04  3:37 ` Mike Anderson [this message]
2010-05-04 10:45   ` [PATCH 9/9] scsi: Add blk_request_aborted check Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=1272944228-30511-10-git-send-email-andmike@linux.vnet.ibm.com \
    --to=andmike@linux.vnet.ibm.com \
    --cc=James.Bottomley@suse.de \
    --cc=dm-devel@redhat.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).