From: Mike Anderson <andmike@linux.vnet.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: Jens Axobe <jens.axboe@oracle.com>,
James Bottomley <James.Bottomley@suse.de>,
dm-devel@redhat.com
Subject: [PATCH 2/9] blk: In elv_abort_queue skip requests with REQ_DONTPREP set
Date: Mon, 3 May 2010 20:37:01 -0700 [thread overview]
Message-ID: <1272944228-30511-3-git-send-email-andmike@linux.vnet.ibm.com> (raw)
In-Reply-To: <1272944228-30511-1-git-send-email-andmike@linux.vnet.ibm.com>
Having REQ_DONTPREP set on a request can indicated that resources have been
allocated for this request. In elv_abort_queue skip requests with
REQ_DONTPREP set to avoid leaking resources.
Signed-off-by: Mike Anderson <andmike@linux.vnet.ibm.com>
Cc: Jens Axobe <jens.axboe@oracle.com>
---
block/elevator.c | 21 ++++++++++++++++++---
1 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/block/elevator.c b/block/elevator.c
index df75676..ac98008 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -807,10 +807,18 @@ int elv_may_queue(struct request_queue *q, int rw)
void elv_abort_queue(struct request_queue *q)
{
- struct request *rq;
+ struct request *rq, *tmp;
+ LIST_HEAD(list);
- while (!list_empty(&q->queue_head)) {
- rq = list_entry_rq(q->queue_head.next);
+ /*
+ * Splice entries to local list, in case the list contains some
+ * requests marked REQ_DONTPREP.
+ */
+ list_splice_init(&q->queue_head, &list);
+
+ list_for_each_entry_safe(rq, tmp, &list, queuelist) {
+ if (rq->cmd_flags & REQ_DONTPREP)
+ continue;
rq->cmd_flags |= REQ_QUIET;
trace_block_rq_abort(q, rq);
/*
@@ -820,6 +828,13 @@ void elv_abort_queue(struct request_queue *q)
blk_start_request(rq);
__blk_end_request_all(rq, -EIO);
}
+
+ /*
+ * In case requests with REQ_DONTPREP where skipped splice the
+ * local list back.
+ */
+ list_splice(&list, &q->queue_head);
+
}
EXPORT_SYMBOL(elv_abort_queue);
--
1.6.6.1
next prev parent reply other threads:[~2010-05-04 3:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 3:36 [PATCH 0/9] blk: scsi: blk abort queue updates Mike Anderson
2010-05-04 3:37 ` [PATCH 1/9] blk: Do not abort requests if queue is stopped Mike Anderson
2010-05-04 10:40 ` Hannes Reinecke
2010-05-04 10:45 ` Jens Axboe
2010-05-05 4:52 ` Mike Anderson
2010-05-05 18:13 ` Mike Christie
2010-05-05 18:18 ` Mike Anderson
2010-05-04 3:37 ` Mike Anderson [this message]
2010-05-04 10:40 ` [PATCH 2/9] blk: In elv_abort_queue skip requests with REQ_DONTPREP set Hannes Reinecke
2010-05-04 10:47 ` Jens Axboe
2010-05-04 17:58 ` Mike Anderson
2010-05-05 8:21 ` Jens Axboe
2010-05-04 3:37 ` [PATCH 3/9] blk: Add a unprep_rq_fn Mike Anderson
2010-05-04 10:41 ` Hannes Reinecke
2010-05-04 3:37 ` [PATCH 4/9] blk: Call unprep_fn from elv_abort_queue is available Mike Anderson
2010-05-04 10:42 ` Hannes Reinecke
2010-05-04 10:42 ` [dm-devel] " Hannes Reinecke
2010-05-04 3:37 ` [PATCH 5/9] scsi: Add a scsi_unprep_fn Mike Anderson
2010-05-04 10:43 ` [dm-devel] " Hannes Reinecke
2010-05-04 10:48 ` Jens Axboe
2010-05-04 3:37 ` [PATCH 6/9] blk: Add request atomic flag for abort Mike Anderson
2010-05-04 10:43 ` [dm-devel] " Hannes Reinecke
2010-05-04 3:37 ` [PATCH 7/9] blk: Mark requests aborted Mike Anderson
2010-05-04 10:44 ` Hannes Reinecke
2010-05-04 3:37 ` [PATCH 8/9] scsi: Add scsi_requeue_request function Mike Anderson
2010-05-04 3:37 ` [PATCH 9/9] scsi: Add blk_request_aborted check Mike Anderson
2010-05-04 10:45 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272944228-30511-3-git-send-email-andmike@linux.vnet.ibm.com \
--to=andmike@linux.vnet.ibm.com \
--cc=James.Bottomley@suse.de \
--cc=dm-devel@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).