From: James Bottomley <James.Bottomley@suse.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Bernd Schubert <bernd.schubert@fastmail.fm>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: SYNCHRONIZE_CACHE command is not retried
Date: Tue, 04 May 2010 10:33:47 -0400 [thread overview]
Message-ID: <1272983627.5255.10.camel@mulgrave.site> (raw)
In-Reply-To: <4BE01C0E.6010501@suse.de>
On Tue, 2010-05-04 at 15:07 +0200, Hannes Reinecke wrote:
> Let's see what the powers that be say to this reasoning.
The actual powers that be are on holiday at the moment, I'm just the dog
sitter. However, I don't think looping forever on unit attention is a
good idea (there are known error cases where devices return unit
attention forever). If the device has device mapper stuff, there should
already be a device_handler module intercepting this sense code, so we
shouldn't switch paths because of it. If there's no device mapper, I
think I'd really rather just add the usual number of retries to the sync
cache command.
I already said I'd be happy with a patch adding this, as well as one
allowing a user configurable timeout for the suspend problem.
James
prev parent reply other threads:[~2010-05-04 14:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 12:23 SYNCHRONIZE_CACHE command is not retried Hannes Reinecke
2010-05-04 12:53 ` Bernd Schubert
2010-05-04 13:07 ` Hannes Reinecke
2010-05-04 14:33 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272983627.5255.10.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=bernd.schubert@fastmail.fm \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox