From: James Bottomley <James.Bottomley@suse.de>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: scsi <linux-scsi@vger.kernel.org>,
Anil Veerabhadrappa <anilgv@broadcom.com>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH] scsi: fix bnx2i build errors
Date: Wed, 05 May 2010 09:54:59 -0400 [thread overview]
Message-ID: <1273067699.5227.56.camel@mulgrave.site> (raw)
In-Reply-To: <20100504103001.33fcbe88.randy.dunlap@oracle.com>
On Tue, 2010-05-04 at 10:30 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> bnx2i should depend on NET since it selects SCSI_ISCSI_ATTRS,
> which depends on NET.
>
> Also move the dependencies together.
>
> The "depends" change fixes multiple build errors when CONFIG_NET is
> not enabled:
> ERROR: "skb_trim" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
> ERROR: "netlink_kernel_create" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
> ERROR: "netlink_kernel_release" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
> ERROR: "skb_pull" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
> ERROR: "init_net" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
> ERROR: "__alloc_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
> ERROR: "netlink_broadcast" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
> ERROR: "kfree_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
> ERROR: "skb_put" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Anil Veerabhadrappa <anilgv@broadcom.com>
> ---
> drivers/scsi/bnx2i/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- lnx-2634-rc6.orig/drivers/scsi/bnx2i/Kconfig
> +++ lnx-2634-rc6/drivers/scsi/bnx2i/Kconfig
> @@ -1,10 +1,11 @@
> config SCSI_BNX2_ISCSI
> tristate "Broadcom NetXtreme II iSCSI support"
> + depends on NET
> + depends on PCI
Actually, let's not fix it this way. While we still have this annoying
bug in the Kconfig system where it doesn't respect the dependencies of a
select, let's not build traps like this ... the rule has to be selected
attributes must select their dependencies, that way the selection just
works(tm).
Of course, fixing Kconfig would be the better option ...
James
---
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 75f2336..804ba3d 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -308,7 +308,8 @@ config SCSI_FC_TGT_ATTRS
config SCSI_ISCSI_ATTRS
tristate "iSCSI Transport Attributes"
- depends on SCSI && NET
+ depends on SCSI
+ select NET
help
If you wish to export transport-specific information about
each attached iSCSI device to sysfs, say Y.
next prev parent reply other threads:[~2010-05-05 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 17:30 [PATCH] scsi: fix bnx2i build errors Randy Dunlap
2010-05-05 13:54 ` James Bottomley [this message]
2010-05-05 15:48 ` Randy Dunlap
2010-05-05 16:02 ` James Bottomley
2010-05-05 16:11 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273067699.5227.56.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=anilgv@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox